From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 2/3] iommu: move pgsize_bitmap from struct iommu_ops to struct iommu_domain Date: Fri, 20 Mar 2015 18:58:29 +0200 Message-ID: <3215851.bbYbp7PLTr@avalon> References: <1426870234-12910-1-git-send-email-will.deacon@arm.com> <1426870234-12910-3-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426870234-12910-3-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Will Deacon Cc: jroedel-l3A5Bk7waGM@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Will, Thank you for the patch. On Friday 20 March 2015 16:50:33 Will Deacon wrote: > struct iommu_ops contains function pointers for IOMMU driver callbacks > in order to implement the core IOMMU API. Amongst these pointers is > an unsigned long pgsize_bitmap field, which is problematic because the > set of supported page sizes is not necessarily the same across all > instances of a given IOMMU type in the system. Furthermore, the set of > supported page sizes may be restricted following domain initialisation > when a particular page table format is chosen for the domain. > > This patch moves the field from iommu_ops into the iommu_domain and > updates all users accordingly. > > Acked-by: Daniel Kurtz > Acked-by: Thierry Reding > Acked-by: Marek Szyprowski > Signed-off-by: Will Deacon For ipmmu-vmsa and shmobile-iommu, Acked-by: Laurent Pinchart > --- > drivers/iommu/amd_iommu.c | 2 +- > drivers/iommu/arm-smmu.c | 12 +++++------- > drivers/iommu/exynos-iommu.c | 3 ++- > drivers/iommu/intel-iommu.c | 2 +- > drivers/iommu/iommu.c | 16 ++++++++-------- > drivers/iommu/ipmmu-vmsa.c | 2 +- > drivers/iommu/msm_iommu.c | 3 ++- > drivers/iommu/omap-iommu.c | 3 ++- > drivers/iommu/rockchip-iommu.c | 2 +- > drivers/iommu/shmobile-iommu.c | 2 +- > drivers/iommu/tegra-gart.c | 2 +- > drivers/iommu/tegra-smmu.c | 3 +-- > drivers/vfio/vfio_iommu_type1.c | 2 +- > include/linux/iommu.h | 4 +--- > 14 files changed, 28 insertions(+), 30 deletions(-) -- Regards, Laurent Pinchart