Linux IOMMU Development
 help / color / mirror / Atom feed
From: Baolu Lu <baolu.lu@linux.intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>, Joerg Roedel <joro@8bytes.org>
Cc: baolu.lu@linux.intel.com, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	iommu@lists.linux.dev, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iommu: change iommu_map_sgtable to return signed values
Date: Thu, 12 Oct 2023 10:06:53 +0800	[thread overview]
Message-ID: <3252ab70-10dc-4eeb-b566-8a89c6b4abac@linux.intel.com> (raw)
In-Reply-To: <06672b96-23fd-424c-8880-1626e7bf119c@moroto.mountain>

On 10/11/23 4:01 PM, Dan Carpenter wrote:
> The iommu_map_sgtable() function returns ssize_t and negative error 
> codes but it's declared as size_t instead. I think that static checkers 
> would have complained if this caused a bug, but even though it doesn't 
> cause a bug, it's definitely worth fixing. Signed-off-by: Dan Carpenter 
> <dan.carpenter@linaro.org> --- include/linux/iommu.h | 2 +- 1 file 
> changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Best regards,
baolu

  reply	other threads:[~2023-10-12  2:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11  8:01 [PATCH] iommu: change iommu_map_sgtable to return signed values Dan Carpenter
2023-10-12  2:06 ` Baolu Lu [this message]
2023-10-16  7:39 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3252ab70-10dc-4eeb-b566-8a89c6b4abac@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=dan.carpenter@linaro.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox