From: "Hook, Gary" <ghook@amd.com>
To: Joerg Roedel <joro@8bytes.org>, Gary R Hook <gary.hook@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd - Use dev_err to send events to the system log
Date: Tue, 13 Feb 2018 10:47:55 -0500 [thread overview]
Message-ID: <325d7406-e01b-f7a1-3da6-390b0cf9bc94@amd.com> (raw)
In-Reply-To: <20180213132216.gyhndywyu23cdzbv@8bytes.org>
On 2/13/2018 8:22 AM, Joerg Roedel wrote:
> On Tue, Jan 30, 2018 at 07:04:27PM -0600, Gary R Hook wrote:
>> + dev_err(dev, "ILLEGAL_DEV_TABLE_ENTRY device=%02x:%02x.%x "
>> + "address=0x%016llx flags=0x%04x]\n",
>> + PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid),
>> + address, flags);
>
> That prints the PCI device-name of the IOMMU in front of the message. Is
> that actually helpful?
>
> If at all, we should print the name of the iommu-device in front of the
> message, not the PCI device that hosts the IOMMU.
so (e.g.):
dev_err(&iommu->dev->dev, "ILLEGAL...
?
I'm okay with that. It does make more sense.
Gary
next prev parent reply other threads:[~2018-02-13 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 1:04 [PATCH] iommu/amd - Use dev_err to send events to the system log Gary R Hook
2018-02-13 13:22 ` Joerg Roedel
2018-02-13 15:47 ` Hook, Gary [this message]
2018-02-13 16:00 ` Joerg Roedel
2018-02-13 19:24 ` Hook, Gary
[not found] ` <f7e7e2c2-c83d-9c4a-f3ac-5c351576b567-5C7GfCeVMHo@public.gmane.org>
2018-02-14 11:49 ` Joerg Roedel
[not found] ` <20180214114957.GI16484-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-02-14 14:58 ` Hook, Gary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325d7406-e01b-f7a1-3da6-390b0cf9bc94@amd.com \
--to=ghook@amd.com \
--cc=gary.hook@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox