From: Vasant Hegde <vasant.hegde@amd.com>
To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@ziepe.ca>,
Alex Deucher <alexander.deucher@amd.com>
Cc: suravee.suthikulpanit@amd.com, wei.huang2@amd.com,
jsnitsel@redhat.com,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Subject: Re: [PATCH v6 00/14] iommu/amd: SVA Support (Part 1) - cleanup/refactoring
Date: Mon, 25 Sep 2023 16:32:40 +0530 [thread overview]
Message-ID: <34d1724f-8ea9-8ad6-986e-618f0380313e@amd.com> (raw)
In-Reply-To: <ZRFjnaztAmplwIBW@8bytes.org>
Joerg,
+ Alex
On 9/25/2023 4:10 PM, Joerg Roedel wrote:
> On Thu, Sep 21, 2023 at 02:21:47PM -0300, Jason Gunthorpe wrote:
>> On Thu, Sep 21, 2023 at 03:19:37PM +0530, Vasant Hegde wrote:
>>> On 9/21/2023 2:51 PM, Vasant Hegde wrote:
>>> This is an independent part of bigger SVA series. This particular series is
>>> tested independently and it works fine. Can you consider picking this series
>>> while we work on sorting out Part3/4?
>>
>> +1
>
> Applied this, thanks.
Thanks!
>
>> Also the v2 API removal:
>>
>> https://lore.kernel.org/linux-iommu/20230921093140.6162-1-vasant.hegde@amd.com/
>
> For that I need more validation that it will not cause regressions on
> older hardware.
AMD GPU driver which was the only in kernel user of iommu_v2 module has removed
iommu_v2 dependency in v6.6. (commit 461f35f014466 - Merge tag
'drm-next-2023-08-30' of git://anongit.freedesktop.org/drm/drm).
Summarizing Alex concern:
AMD IOMMU driver forces passthrough domain for PASID/PRI capable devices. Alex
mentioned if we change this then it may break older GPU hardware.
Part2 of SVA series only removes iommu_v2 related code. It does not touch the
default domain allocation code. Hence it shouldn't cause any regression for GPU
hardware. IMO part2 is good to go.
We will do the default domain allocation cleanup later (after SVA series).
During that time we will account Alex's concern and make sure not to break
existing hardware.
-Vasant
prev parent reply other threads:[~2023-09-25 11:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 9:21 [PATCH v6 00/14] iommu/amd: SVA Support (Part 1) - cleanup/refactoring Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 01/14] iommu/amd: Remove unused amd_io_pgtable.pt_root variable Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 02/14] iommu/amd: Consolidate timeout pre-define to amd_iommu_type.h Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 03/14] iommu/amd: Consolidate logic to allocate protection domain Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 04/14] iommu/amd: Refactor protection domain allocation code Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 05/14] iommu/amd: Introduce helper functions for managing GCR3 table Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 06/14] iommu/amd: Do not set amd_iommu_pgtable in pass-through mode Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 07/14] iommu/amd: Miscellaneous clean up when free domain Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 08/14] iommu/amd: Consolidate feature detection and reporting logic Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 09/14] iommu/amd: Modify logic for checking GT and PPR features Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 10/14] iommu/amd: Rename ats related variables Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 11/14] iommu/amd: Introduce iommu_dev_data.ppr Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 12/14] iommu/amd: Introduce iommu_dev_data.flags to track device capabilities Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 13/14] iommu/amd: Enable device ATS/PASID/PRI capabilities independently Vasant Hegde
2023-09-21 9:21 ` [PATCH v6 14/14] iommu/amd: Initialize iommu_device->max_pasids Vasant Hegde
2023-09-21 9:49 ` [PATCH v6 00/14] iommu/amd: SVA Support (Part 1) - cleanup/refactoring Vasant Hegde
2023-09-21 17:21 ` Jason Gunthorpe
2023-09-25 10:40 ` Joerg Roedel
2023-09-25 11:02 ` Vasant Hegde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34d1724f-8ea9-8ad6-986e-618f0380313e@amd.com \
--to=vasant.hegde@amd.com \
--cc=alexander.deucher@amd.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox