From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010D9C32771 for ; Fri, 10 Jan 2020 01:18:52 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFC0C2077B for ; Fri, 10 Jan 2020 01:18:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFC0C2077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 7D43B204AC; Fri, 10 Jan 2020 01:18:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yKskTm9JcwtI; Fri, 10 Jan 2020 01:18:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 4ED87203A6; Fri, 10 Jan 2020 01:18:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3A383C1796; Fri, 10 Jan 2020 01:18:49 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5A98BC0881 for ; Fri, 10 Jan 2020 01:18:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 475D486ACE for ; Fri, 10 Jan 2020 01:18:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4kyFef3X0Qjl for ; Fri, 10 Jan 2020 01:18:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by fraxinus.osuosl.org (Postfix) with ESMTPS id BB52D86ACB for ; Fri, 10 Jan 2020 01:18:47 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 17:18:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,414,1571727600"; d="scan'208";a="246847040" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga004.fm.intel.com with ESMTP; 09 Jan 2020 17:18:45 -0800 Subject: Re: [PATCH v8 04/10] iommu/vt-d: Support flushing more translation cache types To: Jacob Pan References: <1576524252-79116-1-git-send-email-jacob.jun.pan@linux.intel.com> <1576524252-79116-5-git-send-email-jacob.jun.pan@linux.intel.com> <24cc06da-14ec-908d-361d-a8b321b10852@linux.intel.com> <20200109135038.7608d059@jacob-builder> From: Lu Baolu Message-ID: <34ef67b6-53ef-d15f-0fad-ef4c39719155@linux.intel.com> Date: Fri, 10 Jan 2020 09:17:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200109135038.7608d059@jacob-builder> Content-Language: en-US Cc: "Tian, Kevin" , Raj Ashok , LKML , iommu@lists.linux-foundation.org, David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi, On 1/10/20 5:50 AM, Jacob Pan wrote: > On Thu, 19 Dec 2019 10:46:51 +0800 > Lu Baolu wrote: > >> Hi, >> >> On 12/17/19 3:24 AM, Jacob Pan wrote: >>> When Shared Virtual Memory is exposed to a guest via vIOMMU, >>> scalable IOTLB invalidation may be passed down from outside IOMMU >>> subsystems. This patch adds invalidation functions that can be used >>> for additional translation cache types. >>> >>> Signed-off-by: Jacob Pan >>> --- >>> drivers/iommu/dmar.c | 46 >>> +++++++++++++++++++++++++++++++++++++++++++++ >>> drivers/iommu/intel-pasid.c | 3 ++- include/linux/intel-iommu.h | >>> 21 +++++++++++++++++---- 3 files changed, 65 insertions(+), 5 >>> deletions(-) >>> >>> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c >>> index 3acfa6a25fa2..f2f5d75da94a 100644 >>> --- a/drivers/iommu/dmar.c >>> +++ b/drivers/iommu/dmar.c >>> @@ -1348,6 +1348,20 @@ void qi_flush_iotlb(struct intel_iommu >>> *iommu, u16 did, u64 addr, qi_submit_sync(&desc, iommu); >>> } >>> >>> +/* PASID-based IOTLB Invalidate */ >>> +void qi_flush_iotlb_pasid(struct intel_iommu *iommu, u16 did, u64 >>> addr, u32 pasid, >>> + unsigned int size_order, u64 granu, int ih) >>> +{ >>> + struct qi_desc desc = {.qw2 = 0, .qw3 = 0}; >>> + >>> + desc.qw0 = QI_EIOTLB_PASID(pasid) | QI_EIOTLB_DID(did) | >>> + QI_EIOTLB_GRAN(granu) | QI_EIOTLB_TYPE; >>> + desc.qw1 = QI_EIOTLB_ADDR(addr) | QI_EIOTLB_IH(ih) | >>> + QI_EIOTLB_AM(size_order); >>> + >>> + qi_submit_sync(&desc, iommu); >>> +} >> There's another version of pasid-based iotlb invalidation. >> >> https://lkml.org/lkml/2019/12/10/2128 >> >> Let's consider merging them. >> > Absolutely, the difference i see is that the granularity is explicit > here. Here we do invalidation request from the guest. Perhaps, we can > look at consolidation once this use case is supported? > Looks good to me. :-) Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu