From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC30FC388F7 for ; Wed, 4 Nov 2020 01:08:19 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47632223AB for ; Wed, 4 Nov 2020 01:08:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47632223AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D7AFE8504B; Wed, 4 Nov 2020 01:08:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zd0B0rgSMYfy; Wed, 4 Nov 2020 01:08:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 64E1681E18; Wed, 4 Nov 2020 01:08:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 500EBC0889; Wed, 4 Nov 2020 01:08:18 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 451A7C0889 for ; Wed, 4 Nov 2020 01:08:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 318D321561 for ; Wed, 4 Nov 2020 01:08:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eXjNRHxGf4HG for ; Wed, 4 Nov 2020 01:08:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by silver.osuosl.org (Postfix) with ESMTPS id 371EE21FA8 for ; Wed, 4 Nov 2020 01:08:16 +0000 (UTC) IronPort-SDR: S0OMm6dYRvPwTgdrvyVziChyS4d6b0jusJpqKT1uxiDU0SnEj8UyS9CC5NgpBu1L4FJqMQTi3f C30Z5mA9E4PA== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="156924953" X-IronPort-AV: E=Sophos;i="5.77,449,1596524400"; d="scan'208";a="156924953" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 17:08:15 -0800 IronPort-SDR: 6BDOhAxZNbTJaLs1zswBH9VvB33E9mCxyRQnmqn8lJanXDeBq9qh2Xzq/St4ALkLm6+iLLBUHE /gffL0gGUCwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,449,1596524400"; d="scan'208";a="426518233" Received: from allen-box.sh.intel.com (HELO [10.239.159.139]) ([10.239.159.139]) by fmsmga001.fm.intel.com with ESMTP; 03 Nov 2020 17:08:14 -0800 Subject: Re: [PATCH 1/1] iommu: Fix deferred domain attachment in iommu_probe_device() To: Joerg Roedel References: <20201026063008.24849-1-baolu.lu@linux.intel.com> <20201103132358.GG22888@8bytes.org> From: Lu Baolu Message-ID: <399fbf3e-e940-d2a3-e0e7-20f4da988184@linux.intel.com> Date: Wed, 4 Nov 2020 09:01:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201103132358.GG22888@8bytes.org> Content-Language: en-US Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Joerg, On 11/3/20 9:23 PM, Joerg Roedel wrote: > Hi Baolu, > > On Mon, Oct 26, 2020 at 02:30:08PM +0800, Lu Baolu wrote: >> @@ -264,7 +266,8 @@ int iommu_probe_device(struct device *dev) >> */ >> iommu_alloc_default_domain(group, dev); >> >> - if (group->default_domain) >> + if (group->default_domain && >> + !iommu_is_attach_deferred(group->default_domain, dev)) >> ret = __iommu_attach_device(group->default_domain, dev); > > This is the hotplug path, not used for boot-initialization. Have you > seen failures from the missing check here? I haven't seen any failure. Just wondered why deferred attaching was not checked here. It's fine to me if it's only for hotplug path. Please ignore this change. Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu