From: Shuah Khan <skhan@linuxfoundation.org>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
"tiantao (H)" <tiantao6@hisilicon.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"chenxiang (M)" <chenxiang66@hisilicon.com>,
"hch@lst.de" <hch@lst.de>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] dma-mapping: benchmark: Extract a common header file for map_benchmark definition
Date: Fri, 11 Feb 2022 10:11:57 -0700 [thread overview]
Message-ID: <39bd03ff-d083-5f81-d7d0-f40043cc47a5@linuxfoundation.org> (raw)
In-Reply-To: <d3dd5f61efcb41c981b0971e128da907@hisilicon.com>
On 2/10/22 9:22 PM, Song Bao Hua (Barry Song) wrote:
>
>
>> -----Original Message-----
>> From: tiantao (H)
>> Sent: Friday, February 11, 2022 4:15 PM
>> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; shuah@kernel.org;
>> chenxiang (M) <chenxiang66@hisilicon.com>
>> Cc: iommu@lists.linux-foundation.org; linux-kselftest@vger.kernel.org;
>> linuxarm@openeuler.org
>> Subject: [PATCH] dma-mapping: benchmark: Extract a common header file for
>> map_benchmark definition
>>
>> kernel/dma/map_benchmark.c and selftests/dma/dma_map_benchmark.c
>> have duplicate map_benchmark definitions, which tends to lead to
>> inconsistent changes to map_benchmark on both sides, extract a
>> common header file to avoid this problem.
>>
>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>
> +To: Christoph
>
> Looks like a right cleanup. This will help decrease the maintain
> overhead in the future. Other similar selftests tools are also
> doing this.
>
> Acked-by: Barry Song <song.bao.hua@hisilicon.com>
>
+1 on this cleanup making this code maintainable. We are moving in
the direction of cleaning up defines in selftests for the same
reason.
Let's just make sure this works on older kernels. We do support
mainline kselftest on stable releases. With that:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2022-02-11 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 3:14 [PATCH] dma-mapping: benchmark: Extract a common header file for map_benchmark definition Tian Tao via iommu
2022-02-11 4:22 ` Song Bao Hua (Barry Song) via iommu
2022-02-11 17:11 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39bd03ff-d083-5f81-d7d0-f40043cc47a5@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=chenxiang66@hisilicon.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=shuah@kernel.org \
--cc=song.bao.hua@hisilicon.com \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox