From: Robin Murphy <robin.murphy@arm.com>
To: Rob Clark <robdclark@gmail.com>, linux-kernel@vger.kernel.org
Cc: Rob Clark <robdclark@chromium.org>,
linux-arm-msm@vger.kernel.org,
"open list:DMA MAPPING HELPERS"
<iommu@lists.linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] dma-debug: Make things less spammy under memory pressure
Date: Tue, 31 May 2022 23:00:18 +0100 [thread overview]
Message-ID: <39d1fa65-8e82-721c-171e-ef36bda1c561@arm.com> (raw)
In-Reply-To: <20220531215106.192271-1-robdclark@gmail.com>
On 2022-05-31 22:51, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Ratelimit the error msg to avoid flooding the console.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> kernel/dma/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
> index f8ff598596b8..683966f0247b 100644
> --- a/kernel/dma/debug.c
> +++ b/kernel/dma/debug.c
> @@ -564,7 +564,7 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs)
>
> rc = active_cacheline_insert(entry);
> if (rc == -ENOMEM) {
> - pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
> + pr_err_ratelimited("cacheline tracking ENOMEM, dma-debug disabled\n");
> global_disable = true;
Given that it's supposed to disable itself entirely if it ever gets
here, just how spammy is it exactly?
Thanks,
Robin.
> } else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
> err_printk(entry->dev, entry,
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-05-31 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 21:51 [PATCH] dma-debug: Make things less spammy under memory pressure Rob Clark
2022-05-31 22:00 ` Robin Murphy [this message]
2022-05-31 22:19 ` Rob Clark
2022-06-01 5:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d1fa65-8e82-721c-171e-ef36bda1c561@arm.com \
--to=robin.murphy@arm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox