From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BUG6152_INVALID_DATE_TZ_ABSURD,INCLUDES_PATCH,INVALID_DATE_TZ_ABSURD, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 133C1C43331 for ; Tue, 12 Nov 2019 12:01:52 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2295206BB for ; Tue, 12 Nov 2019 12:01:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2295206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 9B23713B0; Tue, 12 Nov 2019 12:01:51 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 02FCF13A7 for ; Tue, 12 Nov 2019 12:01:51 +0000 (UTC) X-Greylist: delayed 00:30:47 by SQLgrey-1.7.6 Received: from inca-roads.misterjones.org (inca-roads.misterjones.org [213.251.177.50]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 948ABDF for ; Tue, 12 Nov 2019 12:01:50 +0000 (UTC) Received: from www-data by cheepnis.misterjones.org with local (Exim 4.80) (envelope-from ) id 1iUUNw-00062q-I5; Tue, 12 Nov 2019 12:31:00 +0100 To: Robin Murphy Subject: Re: [PATCH] iommu/rockchip: Don't provoke WARN for harmless IRQs X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Date: Tue, 12 Nov 2019 12:40:21 +0109 From: Marc Zyngier In-Reply-To: <82cba203551939399d219e4cb6c602315fd0c410.1573498518.git.robin.murphy@arm.com> References: <82cba203551939399d219e4cb6c602315fd0c410.1573498518.git.robin.murphy@arm.com> Message-ID: <45975bd87e34e9ff6e9656a3235fe074@www.loen.fr> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: robin.murphy@arm.com, joro@8bytes.org, heiko@sntech.de, iommu@lists.linux-foundation.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, anarsoul@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Cc: heiko@sntech.de, Vasily Khoruzhick , linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On 2019-11-11 20:04, Robin Murphy wrote: > Although we don't generally expect IRQs to fire for a suspended > IOMMU, > there are certain situations (particularly with debug options) where > we might legitimately end up with the pm_runtime_get_if_in_use() call > from rk_iommu_irq() returning 0. Since this doesn't represent an > actual > error, follow the other parts of the driver and save the WARN_ON() > condition for a genuine negative value. Even if we do have spurious > IRQs due to a wedged VOP asserting the shared line, it's not this > driver's job to try to second-guess the IRQ core to warn about that. > > Reported-by: Vasily Khoruzhick > Signed-off-by: Robin Murphy > --- > drivers/iommu/rockchip-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/rockchip-iommu.c > b/drivers/iommu/rockchip-iommu.c > index 4dcbf68dfda4..bd7e9b1e40ac 100644 > --- a/drivers/iommu/rockchip-iommu.c > +++ b/drivers/iommu/rockchip-iommu.c > @@ -527,7 +527,7 @@ static irqreturn_t rk_iommu_irq(int irq, void > *dev_id) > int i, err; > > err = pm_runtime_get_if_in_use(iommu->dev); > - if (WARN_ON_ONCE(err <= 0)) > + if (!err || WARN_ON_ONCE(err < 0)) > return ret; > > if (WARN_ON(clk_bulk_enable(iommu->num_clocks, iommu->clocks))) Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny... _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu