From: Scott Wood <scottwood@freescale.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Ohad Ben-Cohen <ohad@wizery.com>,
David Woodhouse <dwmw2@infradead.org>,
David Brown <davidb@codeaurora.org>,
Tony Lindgren <tony@atomide.com>, Stuart Yoder <b08248@gmail.com>,
Hiroshi Doyu <hdoyu@nvidia.com>
Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute
Date: Thu, 26 Jan 2012 12:26:58 -0600 [thread overview]
Message-ID: <4F219AF2.6070108@freescale.com> (raw)
In-Reply-To: <201201191727.10176.laurent.pinchart@ideasonboard.com>
On 01/19/2012 10:27 AM, Laurent Pinchart wrote:
> Hi Joerg,
>
> On Thursday 19 January 2012 17:07:39 Joerg Roedel wrote:
>> On Thu, Jan 19, 2012 at 04:46:13PM +0100, Laurent Pinchart wrote:
>>>> +struct iommu_domain_geometry {
>>>> + u64 aperture_start; /* First address that can be mapped */
>>>> + u64 aperture_end; /* Last address that can be mapped */
>>>
>>> Would it make sense to use a platform-dependent type that represents
>>> physical addresses instead of u64 ?
>>
>> Well, u64 is a catch-all datatype which should suit all drivers. Is this
>> a problem at ARM?
>
> No, it's not a problem for ARM, at least to my knowledge. It just struck me as
> weird, as we have specific data types for other kinds of addresses (such as
> dma_addr_t).
If we want to be able to expose these attribute structs to userspace via
vfio, we'll want to stick with fixed size types.
-Scott
prev parent reply other threads:[~2012-01-26 18:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1326983405-319-1-git-send-email-joerg.roedel@amd.com>
[not found] ` <1326983405-319-3-git-send-email-joerg.roedel@amd.com>
[not found] ` <1326983405-319-3-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2012-01-19 17:16 ` [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Sethi Varun-B16395
[not found] ` <C5ECD7A89D1DC44195F34B25E172658D038749@039-SN2MPN1-011.039d.mgd.msft.net>
[not found] ` <C5ECD7A89D1DC44195F34B25E172658D038749-RL0Hj/+nBVCMXPU/2EZmt64g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-01-20 16:03 ` Joerg Roedel
2012-01-26 18:25 ` Scott Wood
2012-01-26 18:31 ` Joerg Roedel
2012-01-26 18:42 ` Scott Wood
[not found] ` <4F219E82.106-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-01-26 18:51 ` Joerg Roedel
2012-01-26 19:00 ` Scott Wood
[not found] ` <4F21A2D5.6000204-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-01-26 19:44 ` Joerg Roedel
2012-01-26 20:02 ` Scott Wood
[not found] ` <4F21B152.3010103-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-01-27 11:01 ` Joerg Roedel
2012-01-27 21:22 ` Scott Wood
[not found] ` <4F2315A3.80909-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-01-30 14:24 ` Joerg Roedel
2012-01-30 20:21 ` Scott Wood
[not found] ` <20120126185101.GJ19255-5C7GfCeVMHo@public.gmane.org>
2012-01-30 6:27 ` Sethi Varun-B16395
[not found] ` <C5ECD7A89D1DC44195F34B25E172658D041E81-RL0Hj/+nBVDAtPZc1oz0FK4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-01-30 14:30 ` Joerg Roedel
[not found] ` <1326983405-319-1-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>
2012-01-20 6:14 ` [PATCH 0/5] IOMMU: Make IOMMU-API ready for GART-like hardware Hiroshi Doyu
[not found] ` <20120120.081403.2268989617582455160.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-01-20 16:05 ` joerg.roedel-5C7GfCeVMHo
[not found] ` <201201191646.13798.laurent.pinchart@ideasonboard.com>
[not found] ` <20120119160739.GB2205@amd.com>
[not found] ` <201201191727.10176.laurent.pinchart@ideasonboard.com>
[not found] ` <201201191727.10176.laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2012-01-20 5:44 ` [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Hiroshi Doyu
2012-01-20 16:01 ` Joerg Roedel
[not found] ` <20120120160128.GF2205-5C7GfCeVMHo@public.gmane.org>
2012-02-01 9:37 ` Sethi Varun-B16395
2012-01-26 18:26 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F219AF2.6070108@freescale.com \
--to=scottwood@freescale.com \
--cc=b08248@gmail.com \
--cc=davidb@codeaurora.org \
--cc=dwmw2@infradead.org \
--cc=hdoyu@nvidia.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).