From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [v3 1/2] iommu/tegra: smmu: Remove unnecessary sanity check at alloc_pdir() Date: Fri, 29 Jun 2012 09:34:21 -0600 Message-ID: <4FEDCAFD.3070609@wwwdotorg.org> References: <20120628.221945.1306825810095951985.hdoyu@nvidia.com> <1340950527-16482-1-git-send-email-hdoyu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1340950527-16482-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Hiroshi DOYU Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 06/29/2012 12:15 AM, Hiroshi DOYU wrote: > alloc_pdir() is called with smmu->as[?].pdir_page == NULL. No need to > check pdir_page again inside alloc_pdir(). Both patches, Acked-by: Stephen Warren