From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CEB13822BE for ; Wed, 4 Mar 2026 09:34:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616869; cv=none; b=jhge1vTaRz8VnHk7kWAYf4yVY7cxagL9QaKTLua2kzAU5P49oZDQQRqQKrgRvjhdX2+CBbt1j/ZfQ+FgV179C3BMwCY2EiG+F3wEwEtmnvISL7ktIrVxloW/ZXT2rIMKGi86M7P9/GghK9zne5tTjdxugS0H9C9y4rUuMMfyfCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616869; c=relaxed/simple; bh=6qNs5bvMZfHwnPOBKJIFPFz6WDohu397FZ3wycyW/AE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OQmXLG/qUwPx8m9tDuIx1hjpKOzenT6UXwlV2q5fOvFNTtcpdr9s30xLQM2gRVpwoNv9UvXkIZBPUcytBNt8Y/jalUeHdY2asKVyeMRbmock+1EMVX5QSO0FXcFbz8pKB+8qB/8pmbk+ZBuC0BvfklPJvWJgCwlhyBXhWWNT104= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JFVTiT7l; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vz0Bua+X; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JFVTiT7l"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vz0Bua+X" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245SND21421862 for ; Wed, 4 Mar 2026 09:34:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HgNePX7ca+FZHnkRpuhdJQZhOY6UQv+RvgcyupQpELQ=; b=JFVTiT7lxucAne5+ vWI+HQTpVk9V3jWmx1PWUucrFvamP0yDOFY034alLz3ZBgzIEfMi0MS4uquN1hh8 EI7aXuxp6dMz6qO68oU/aQSWUICNJo/sGcNoD0kPndEVtSWs5OCjVP5rcLH80Phg ky3wGQTwGMI2mB5E91AT27+H0OF6l0sY8Q3oWToivevSOK2GADQjRFKwWcBWEA11 9S/eTjbdqGKh/aZMhmaHEf1pdgu2dgjd13zO95DicZf3Ff6fn+rEkPSwwJQABuHd scgJ1dbD5faRcuu9tqpogs2bthEi90+/7K8PlySiEJVEWT4ZR/QIh7aqipwVG5tU 9sDJBA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpe8u0w3e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 09:34:27 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3594620fe97so32488953a91.1 for ; Wed, 04 Mar 2026 01:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772616866; x=1773221666; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HgNePX7ca+FZHnkRpuhdJQZhOY6UQv+RvgcyupQpELQ=; b=Vz0Bua+XjJHDsn905M93LfWcSGrShhUWG0k5CuVZ5TWOzzaSYguLYMcZ6w/ZU6Lx/K 4yBjgPjpUCqRZ3Y22hw4RtVY/jf4iQr0FjyrojliuYS7TK0Uxn/XsfPV8URAlSKGHzTs 71ZP/YzyZY0R0DiI8PHRxCOF4HTuJ4YOO9NRzKBiK423qgpmn1YnbJCppFmWjGbuQvL7 IguYsXx+MRy6/VpzSzYbjMP/p4ow36OVV9T/PRHXyrCrOqtHhKqMADTxmgrAJyT2KHGn e5JTjY9tYMg2mrow8oEFX7H4r4x/+49yMjc1KArSNg8uuzrZWHTPmT25vl2kLebl89ZQ DHnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772616866; x=1773221666; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HgNePX7ca+FZHnkRpuhdJQZhOY6UQv+RvgcyupQpELQ=; b=MvgRS1gJ1qTnBplfVU8tgVWIOTJftn7DZlkTveqkyKEXvlkczIxTn2doQ/4IHwRgEj lo9Ylf6kYhRjlEJSd8xlkknfZJHf66x9dhFAaNUtExdidpZk2+wjzElcyiGENW5wB2hP 0NNiZjhXjFtpnRX44GqoQnzUo1ciU8azS9MIelE61KubH6YkZDP+TKen0l28dN16MP7I OEEOa5yjSxsH7q8hfpQvrl1MBLIo1kezVT3tHYjg61piC2uk0K9Ht9FBgQnAaLp/hkYU EFs1OXOKqUOJLBuRvtxFpyH+TNge7yL+XVyMif2GfN5bEdRDDLPmbnWMHE6b1h9XWJ/u L1pQ== X-Forwarded-Encrypted: i=1; AJvYcCX41Q3sKcnAl7eojOXc+Jl/12oAci76UeKW1O47ypXJ3E+E7m89yvF6JpOKa0Tu217fxXGXJw==@lists.linux.dev X-Gm-Message-State: AOJu0YzsD+ZOlMdKzmAwF9YJxFFF3mgn/qDU2T76Q0Lmtos3hmtqT9sw EOd6DGi7ypkRdSIWv+KdKG8i9Yf5t21V0HsvCCy7ZuABCWXuQRKRenxP8YSCUQwviKaiIWv3NNd 3uoZ4MsTcKIlZdAoXy4ZDP6ZnrpaNkw5h4zfP2JjBXkfqZ9xbWK5Ej09ULg== X-Gm-Gg: ATEYQzzVlLGLRMtbHHHKODu7xqi2fGhCRfFoQ6oFsxHTrb/zy5C26p2wfeM4Nim9kCZ 8j0ZFdLhVfEPJPQ0cHLsGuVOQr06mn7F6z0APidQ9Aol52zDGJYvFzooFshkRnuiK5pwzbL3JQo sdELhRCfysCBja0Vd6MlSb3q4f7YDqcItCKCUNyFT1ki0EBp1fYhnWafkd1h8MY84JUdcpLbdQB coP/CaPC3mtwF0VxZ3qbjdE6yZ7MPezZX/PnkSfaPS/DEwpVAcfKmCMuRkjudBXpUL/FwVcY8HK ciRu+ZVLiphNok0IeEpTYDScajvbAnPj1UeApq1PNIP3pUarO1B9IP9GML+kCFdjG+YGhNoNDao +SLdfVqjhy8htnt5aiCQGZN+8MNf39f0f2GX86F5aKi4bPd2FJB1uk5pT X-Received: by 2002:a17:90b:2691:b0:349:2154:eef4 with SMTP id 98e67ed59e1d1-359a69c0d3dmr1241327a91.5.1772616866187; Wed, 04 Mar 2026 01:34:26 -0800 (PST) X-Received: by 2002:a17:90b:2691:b0:349:2154:eef4 with SMTP id 98e67ed59e1d1-359a69c0d3dmr1241312a91.5.1772616865529; Wed, 04 Mar 2026 01:34:25 -0800 (PST) Received: from [10.219.57.109] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359a8d65b31sm500720a91.0.2026.03.04.01.34.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 01:34:25 -0800 (PST) Message-ID: <4bc86c4d-3a4e-4ece-a01f-dce735ee9bd3@oss.qualcomm.com> Date: Wed, 4 Mar 2026 15:04:13 +0530 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/3] of: factor arguments passed to of_map_id() into a struct To: Dmitry Baryshkov Cc: Nipun Gupta , Nikhil Agarwal , Joerg Roedel , Will Deacon , Robin Murphy , Marc Zyngier , Lorenzo Pieralisi , Thomas Gleixner , Rob Herring , Saravana Kannan , Richard Zhu , Lucas Stach , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Konrad Dybcio , Bjorn Andersson , Conor Dooley , Krzysztof Kozlowski , Prakash Gupta , Vikash Garodia , linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, imx@lists.linux.dev, xen-devel@lists.xenproject.org, linux-arm-msm@vger.kernel.org, Charan Teja Kalla References: <20260301-parse_iommu_cells-v9-0-4d1bceecc5e1@oss.qualcomm.com> <20260301-parse_iommu_cells-v9-2-4d1bceecc5e1@oss.qualcomm.com> Content-Language: en-US From: Vijayanand Jitta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: KmOekjL5wp-oWas_FwbEfTL1B_zxC2mD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA3MiBTYWx0ZWRfX5CrFTLEtr8Zt MnEBJHMO2SgjDyfAuUW8qyIldN9nfbAswhvdJcYfX20RBhjTJIdUCO5YmwYnSDfQzLKxbXnwNQd HqIX70PyvaXly4Yg/cB0QxNES2SlwSlS/zffzTdtTbd4zjnHY3l/q29+QUi2bg62le6G0PEeNpl XwhahvTaggA6tGjfY91Q1tcS8ad8ipn842/xMsjPiNw7YvRmrZuNezEMYEACl2i5LYSZX+4tbKF +rbId8pa171Klg91zLVxvkido2lSk7RTy/55z2ocN+0fH57JTuzvKBqhUCxb9anTHob/2NXVKGK wxYWTHaxTRebee7bhGvWN3Wjng/3a5UVJClDJrqhq6x6HYwlW+xdBL4PLajEjfvfP3Qe0j1CIoa NROtJmhaIUcSj8G9W9f5G1AQL/xA8EdSTAwZHigMpOgIqkUG/oASE7a+c/uCkv6ugyT8CM9S8L7 n9PcS2dJYO2Gdt25hoA== X-Authority-Analysis: v=2.4 cv=FpAIPmrq c=1 sm=1 tr=0 ts=69a7fca3 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=MLUpyK7X_zb698vRSG8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: KmOekjL5wp-oWas_FwbEfTL1B_zxC2mD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 malwarescore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040072 On 3/1/2026 3:32 PM, Dmitry Baryshkov wrote: > On Sun, Mar 01, 2026 at 02:04:20PM +0530, Vijayanand Jitta wrote: >> From: Charan Teja Kalla >> >> Change of_map_id() to take a pointer to struct of_phandle_args >> instead of passing target device node and translated IDs separately. >> Update all callers accordingly. >> >> Subsequent patch will make use of the args_count field in >> struct of_phandle_args. >> >> Suggested-by: Rob Herring (Arm) >> Signed-off-by: Charan Teja Kalla >> Signed-off-by: Vijayanand Jitta >> --- >> drivers/iommu/of_iommu.c | 2 +- >> drivers/of/base.c | 37 +++++++++++++++++------------------ >> drivers/pci/controller/dwc/pci-imx6.c | 8 +++++++- >> drivers/pci/controller/pcie-apple.c | 4 +++- >> drivers/xen/grant-dma-ops.c | 2 +- >> include/linux/of.h | 21 +++++++++++++------- >> 6 files changed, 44 insertions(+), 30 deletions(-) >> > >> @@ -2193,11 +2193,10 @@ int of_map_id(const struct device_node *np, u32 id, >> } >> >> pr_info("%pOF: no %s translation for id 0x%x on %pOF\n", np, map_name, >> - id, target && *target ? *target : NULL); >> + id, arg->np ? arg->np : NULL); > > Is it just 'args->np' then? If it's NULL, it's NULL anyway. > Right, will update this. >> >> /* Bypasses translation */ >> - if (id_out) >> - *id_out = id; >> + arg->args[0] = id; >> return 0; >> } >> EXPORT_SYMBOL_GPL(of_map_id); >> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c >> index bff8289f804a..74fc603b3f84 100644 >> --- a/drivers/pci/controller/dwc/pci-imx6.c >> +++ b/drivers/pci/controller/dwc/pci-imx6.c >> @@ -1139,12 +1139,18 @@ static int imx_pcie_add_lut_by_rid(struct imx_pcie *imx_pcie, u32 rid) >> { >> struct device *dev = imx_pcie->pci->dev; >> struct device_node *target; >> + struct of_phandle_args iommu_spec = { .args_count = 1 }; >> u32 sid_i, sid_m; >> int err_i, err_m; >> u32 sid = 0; >> >> target = NULL; >> - err_i = of_map_iommu_id(dev->of_node, rid, &target, &sid_i); >> + err_i = of_map_iommu_id(dev->of_node, rid, &iommu_spec); >> + if (!err_i) { >> + target = iommu_spec.np; >> + sid_i = iommu_spec.args[0]; >> + } >> + >> if (target) { >> of_node_put(target); >> } else { >> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c >> index a0937b7b3c4d..e1d4b37d200d 100644 >> --- a/drivers/pci/controller/pcie-apple.c >> +++ b/drivers/pci/controller/pcie-apple.c >> @@ -755,6 +755,7 @@ static int apple_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_d >> { >> u32 sid, rid = pci_dev_id(pdev); >> struct apple_pcie_port *port; >> + struct of_phandle_args iommu_spec = { .args_count = 1 }; >> int idx, err; >> >> port = apple_pcie_get_port(pdev); >> @@ -764,10 +765,11 @@ static int apple_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_d >> dev_dbg(&pdev->dev, "added to bus %s, index %d\n", >> pci_name(pdev->bus->self), port->idx); >> >> - err = of_map_iommu_id(port->pcie->dev->of_node, rid, NULL, &sid); >> + err = of_map_iommu_id(port->pcie->dev->of_node, rid, &iommu_spec); >> if (err) >> return err; > > of_node_put(iommu_spec.np); > Sure, will add this. >> >> + sid = iommu_spec.args[0]; >> mutex_lock(&port->pcie->lock); >> >> idx = bitmap_find_free_region(port->sid_map, port->sid_map_sz, 0); >> diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c >> index 1b7696b2d762..5f1d6540049a 100644 >> --- a/drivers/xen/grant-dma-ops.c >> +++ b/drivers/xen/grant-dma-ops.c >> @@ -325,7 +325,7 @@ static int xen_dt_grant_init_backend_domid(struct device *dev, >> struct pci_dev *pdev = to_pci_dev(dev); >> u32 rid = PCI_DEVID(pdev->bus->number, pdev->devfn); >> >> - if (of_map_iommu_id(np, rid, &iommu_spec.np, iommu_spec.args)) { >> + if (of_map_iommu_id(np, rid, &iommu_spec)) { >> dev_dbg(dev, "Cannot translate ID\n"); >> return -ESRCH; >> } >> diff --git a/include/linux/of.h b/include/linux/of.h >> index 824649867810..9d72d76f909d 100644 >> --- a/include/linux/of.h >> +++ b/include/linux/of.h >> @@ -463,7 +463,7 @@ bool of_console_check(const struct device_node *dn, char *name, int index); >> >> int of_map_id(const struct device_node *np, u32 id, >> const char *map_name, const char *map_mask_name, >> - struct device_node **target, u32 *id_out); >> + struct of_phandle_args *arg); >> >> phys_addr_t of_dma_get_max_cpu_address(struct device_node *np); >> >> @@ -929,7 +929,7 @@ static inline void of_property_clear_flag(struct property *p, unsigned long flag >> >> static inline int of_map_id(const struct device_node *np, u32 id, >> const char *map_name, const char *map_mask_name, >> - struct device_node **target, u32 *id_out) >> + struct of_phandle_args *arg) >> { >> return -EINVAL; >> } >> @@ -1458,17 +1458,24 @@ static inline int of_property_read_s32(const struct device_node *np, >> } >> >> static inline int of_map_iommu_id(const struct device_node *np, u32 id, >> - struct device_node **target, u32 *id_out) >> + struct of_phandle_args *arg) > > Document that it's the caller's responsibility to of_node_put() returned > node. As it can be seen from the previous comment, it's not obvious. > Sure, will add comment regarding this. >> { >> - return of_map_id(np, id, "iommu-map", "iommu-map-mask", >> - target, id_out); >> + return of_map_id(np, id, "iommu-map", "iommu-map-mask", arg); >> } >> >> static inline int of_map_msi_id(const struct device_node *np, u32 id, >> struct device_node **target, u32 *id_out) > > Is there a reason for chaning the of_map_iommu_id() args but not > of_map_msi_id() args? > Thanks for pointing this out. I’ll update the series to keep of_map_iommu_id() and of_map_msi_id() aligned. >> { >> - return of_map_id(np, id, "msi-map", "msi-map-mask", >> - target, id_out); >> + struct of_phandle_args msi_spec = { .np = *target, .args_count = 1 }; > > Which driver passes something being worth of storing in .np? > You're right, There is no need to store these input args. Will remove these initializations. Thanks, Vijay >> + int ret; >> + >> + ret = of_map_id(np, id, "msi-map", "msi-map-mask", &msi_spec); >> + if (!ret) { >> + *target = msi_spec.np; >> + *id_out = msi_spec.args[0]; >> + } >> + >> + return ret; >> } >> >> #define of_for_each_phandle(it, err, np, ln, cn, cc) \ >> >> -- >> 2.34.1 >> >