From: Suravee Suthikulpanit <suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312
Date: Thu, 18 Apr 2013 13:56:42 -0500 [thread overview]
Message-ID: <517041EA.70407@amd.com> (raw)
In-Reply-To: <20130418183538.GA17148-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
On 4/18/2013 1:35 PM, Joerg Roedel wrote:
> On Thu, Apr 18, 2013 at 11:59:58AM -0500, Suthikulpanit, Suravee wrote:
>> One last concern I have for this patch is the case when we re-enable
>> the interrupt, then another interrupt happens while we processing
>> the log and set the bit. If the interrupt thread doesn't check this
>> right before the thread exits the handler. We could still end up
>> leaving the interrupt disabled.
> That can't happen, the patch checks whether the bit is really 0 and then
> it processes the event/ppr-log entries. If any new entry is queued while
> we process the logs another interrupt will be fired and the irq-thread
> will run again. So we will not miss any log entry.
According to the "kernel/irq/handle.c:irq_wake_thread()", I thought that
for the threaded IRQ, if the system getting a new interrupt from the
device while the thread is running, it will just return and do nothing.
Suravee
> Joerg
>
>
>
next prev parent reply other threads:[~2013-04-18 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 7:07 [PATCH 1/2 V2] iommu/amd: Add workaround for ERBT1312 suravee.suthikulpanit-5C7GfCeVMHo
2013-04-18 16:02 ` Joerg Roedel
2013-04-18 16:13 ` Suravee Suthikulanit
[not found] ` <51701B9F.10003-5C7GfCeVMHo@public.gmane.org>
2013-04-18 16:28 ` Joerg Roedel
[not found] ` <20130418162856.GA13891-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-18 16:59 ` Suravee Suthikulanit
[not found] ` <5170268E.8080706-5C7GfCeVMHo@public.gmane.org>
2013-04-18 18:35 ` Joerg Roedel
[not found] ` <20130418183538.GA17148-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-18 18:56 ` Suravee Suthikulpanit [this message]
[not found] ` <517041EA.70407-5C7GfCeVMHo@public.gmane.org>
2013-04-18 20:06 ` Joerg Roedel
[not found] ` <20130418200613.GB17148-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-22 21:43 ` Suravee Suthikulanit
2013-04-23 13:22 ` Don Dutile
[not found] ` <51768B25.1060501-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-24 10:46 ` Joerg Roedel
[not found] ` <20130424104616.GH17148-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-24 13:52 ` Don Dutile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517041EA.70407@amd.com \
--to=suravee.suthikulpanit-5c7gfcevmho@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).