Linux IOMMU Development
 help / color / mirror / Atom feed
From: Anthony DeRobertis <aderobertis-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: PROBLEM: do_IRQ: [number] No irq handler for vector (irq -1)
Date: Wed, 22 Jan 2014 14:41:06 -0500	[thread overview]
Message-ID: <52E01ED2.4080604@metrics.net> (raw)
In-Reply-To: <20140122181707.GA14646-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>

I was looking through those files a bit, and notice there is a 
iommu_disable_irq_remapping. I added some printk's to it, and it isn't 
being called when the BIOS workaround is hit.

 From the code, I gather that it should be disabled at boot, and the 
disable_irq_remap flag works by just pretending its not supported, so it 
never gets enabled.

However, I see in the enable path (intel_enable_irq_remapping) there is 
this:

		/*
		 * Disable intr remapping and queued invalidation, if already
		 * enabled prior to OS handover.
		 */
		iommu_disable_irq_remapping(iommu);

It sounds like someone found a BIOS before that hands off to Linux with 
it already enabled.

So, I added a call to disable_irq_remapping, but it turns out that this 
BIOS doesn't do that. So doesn't help here.

Also, I notice that iommu_disable_irq_remapping looks suspicious as its 
weird that GSTS is being read with both readl and dmar_readq. I think 
readl is correct, as I think the Intel spec says its a 32-bit field.

  parent reply	other threads:[~2014-01-22 19:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 17:41 PROBLEM: do_IRQ: [number] No irq handler for vector (irq -1) Anthony DeRobertis
     [not found] ` <52D576E3.8050006-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
2014-01-16  4:03   ` Alex Williamson
     [not found]     ` <1389844985.8705.45.camel-xdHQ/5r00wBBDLzU/O5InQ@public.gmane.org>
2014-01-16 12:16       ` Neil Horman
     [not found]         ` <20140116121617.GA9984-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-01-16 17:08           ` Anthony DeRobertis
     [not found]             ` <52D8120D.7090606-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
2014-01-16 18:21               ` Neil Horman
     [not found]                 ` <20140116182134.GC9984-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-01-16 20:07                   ` Anthony DeRobertis
     [not found]                     ` <52D83BF9.7040502-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
2014-01-17 14:08                       ` Neil Horman
     [not found]                         ` <20140117140831.GA19452-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-01-17 18:52                           ` Anthony DeRobertis
     [not found]                             ` <52D97BFB.1020106-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
2014-01-17 20:27                               ` Neil Horman
     [not found]                                 ` <20140117202712.GC19452-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-01-17 22:33                                   ` Anthony DeRobertis
     [not found]                                     ` <52D9AFBB.5080203-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
2014-01-20 12:26                                       ` Neil Horman
     [not found]                                         ` <20140120122630.GB22690-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-01-22 16:29                                           ` Anthony DeRobertis
     [not found]                                             ` <52DFF1FE.2080805-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
2014-01-22 18:17                                               ` Neil Horman
     [not found]                                                 ` <20140122181707.GA14646-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-01-22 19:41                                                   ` Anthony DeRobertis [this message]
     [not found]                                                     ` <52E01ED2.4080604-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
2014-01-23 12:37                                                       ` Neil Horman
     [not found]                                                         ` <20140123123743.GA26800-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-01-23 19:24                                                           ` Anthony DeRobertis
     [not found]                                                             ` <52E16C56.9000709-VnMYzjHJ8tfR7s880joybQ@public.gmane.org>
2014-01-23 21:51                                                               ` Neil Horman
2014-01-16 17:17           ` Anthony DeRobertis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E01ED2.4080604@metrics.net \
    --to=aderobertis-vnmyzjhj8tfr7s880joybq@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox