From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulanit Subject: Re: [PATCH] iommu/amd: Fix logics to determine and checking max PASID Date: Wed, 5 Mar 2014 17:08:41 -0600 Message-ID: <5317AE79.6090606@amd.com> References: <1394046068-3858-1-git-send-email-suravee.suthikulpanit@amd.com> <20140305223544.GA2813@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140305223544.GA2813-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, jay.cornwall-5C7GfCeVMHo@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kim.naru-5C7GfCeVMHo@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 3/5/2014 4:35 PM, Joerg Roedel wrote: >> - cmd->data[1] = pasid & PASID_MASK; >> >+ cmd->data[1] = pasid & amd_iommu_max_pasid; > ... masking out the other bits is redundant. > > > Joerg Agree. I can take out the masking stuff here, but I think we should be using the amd_iommu_max_pasid instead of hard coded PASID_MASK for the rest. Suravee