From: Jeff Liu <jeff.liu@oracle.com>
To: joro@8bytes.org
Cc: iommu@lists.linux-foundation.org, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 09/24] drivers/iommu: check actual error on iommu_init
Date: Tue, 17 Jun 2014 22:29:19 +0800 [thread overview]
Message-ID: <53A050BF.3000101@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
kset_create_and_add() has been fixed to return the actual error
code ptr rather than NULL, so update iommu_init() to check the
return value via IS_ERR() accordingly.
Cc: Joerg Roedel <joro@8bytes.org>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
drivers/iommu/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index e5555fc..297b5ad 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -925,7 +925,7 @@ static int __init iommu_init(void)
ida_init(&iommu_group_ida);
mutex_init(&iommu_group_mutex);
- BUG_ON(!iommu_group_kset);
+ BUG_ON(IS_ERR(iommu_group_kset));
return 0;
}
--
1.8.3.2
next reply other threads:[~2014-06-17 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 14:29 Jeff Liu [this message]
[not found] ` <53A050BF.3000101-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-06-17 15:21 ` [PATCH 09/24] drivers/iommu: check actual error on iommu_init Joerg Roedel
[not found] ` <20140617152154.GE31771-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-06-17 19:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A050BF.3000101@oracle.com \
--to=jeff.liu@oracle.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox