From: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 05/12] memory: Add NVIDIA Tegra memory controller support
Date: Thu, 30 Oct 2014 19:03:42 +0900 [thread overview]
Message-ID: <54520CFE.9060907@nvidia.com> (raw)
In-Reply-To: <1413196434-5292-5-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> diff --git a/drivers/memory/tegra/tegra124-mc.c b/drivers/memory/tegra/tegra124-mc.c
...
> +static const struct tegra_smmu_swgroup tegra124_swgroups[] = {
> + { .swgroup = TEGRA_SWGROUP_DC, .reg = 0x240 },
> + { .swgroup = TEGRA_SWGROUP_DCB, .reg = 0x244 },
> + { .swgroup = TEGRA_SWGROUP_AFI, .reg = 0x238 },
> + { .swgroup = TEGRA_SWGROUP_AVPC, .reg = 0x23c },
> + { .swgroup = TEGRA_SWGROUP_HDA, .reg = 0x254 },
> + { .swgroup = TEGRA_SWGROUP_HC, .reg = 0x250 },
> + { .swgroup = TEGRA_SWGROUP_MSENC, .reg = 0x264 },
> + { .swgroup = TEGRA_SWGROUP_PPCS, .reg = 0x270 },
> + { .swgroup = TEGRA_SWGROUP_SATA, .reg = 0x274 },
> + { .swgroup = TEGRA_SWGROUP_VDE, .reg = 0x27c },
> + { .swgroup = TEGRA_SWGROUP_ISP2, .reg = 0x258 },
> + { .swgroup = TEGRA_SWGROUP_XUSB_HOST, .reg = 0x288 },
> + { .swgroup = TEGRA_SWGROUP_XUSB_DEV, .reg = 0x28c },
> + { .swgroup = TEGRA_SWGROUP_ISP2B, .reg = 0xaa4 },
> + { .swgroup = TEGRA_SWGROUP_TSEC, .reg = 0x294 },
> + { .swgroup = TEGRA_SWGROUP_A9AVP, .reg = 0x290 },
> + { .swgroup = TEGRA_SWGROUP_GPU, .reg = 0xaa8 },
I had to change the .reg of TEGRA_SWGROUP_GPU to 0xaac to get the IOMMU
to work with GK20A. The reason is still not completely clear to me, but
if you look at the TRM you see that 0xaa8 is basically constant, with
the SMMU translation bit hardcoded to DISABLE (and the ASID field being
meaningless in that case). However right after that register you have a
functional one named GPUB instead of GPU, and this one is fully
writeable (and has the expected effect).
I will try to get more information about the why of this, but for now
this setting is what works for me.
next prev parent reply other threads:[~2014-10-30 10:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 10:33 [PATCH v3 01/12] clk: tegra: Implement memory-controller clock Thierry Reding
[not found] ` <1413196434-5292-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-13 10:33 ` [PATCH 02/12] amba: Add Kconfig file Thierry Reding
2014-10-13 10:33 ` [PATCH v4 03/12] ARM: tegra: Move AHB Kconfig to drivers/amba Thierry Reding
2014-10-13 10:33 ` [PATCH 04/12] of: Add NVIDIA Tegra memory controller binding Thierry Reding
2014-10-13 10:33 ` [PATCH v4 05/12] memory: Add NVIDIA Tegra memory controller support Thierry Reding
[not found] ` <1413196434-5292-5-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-15 22:05 ` Olof Johansson
[not found] ` <CAOesGMjMcqa_wE7rfA42QyvF7yxAkgjEN+-0UVMuErnjHr4zkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 15:32 ` Thierry Reding
2014-10-15 22:09 ` Olof Johansson
[not found] ` <CAOesGMgDE_PZHrrEhntnce2AMsdtAb9+i5XuxP-Q7j--432zpw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 15:08 ` Thierry Reding
[not found] ` <20141030150839.GG20072-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-10-31 13:27 ` Thierry Reding
[not found] ` <20141031132740.GA9371-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-11-01 5:38 ` Alexandre Courbot
[not found] ` <CAAVeFuKgMAF4LML5G=2k00No4AKDj7MTHB6ByXEvPzaSsAPUXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-03 8:22 ` Thierry Reding
[not found] ` <20141103082201.GC21002-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-11-03 8:40 ` Alexandre Courbot
2014-10-30 10:03 ` Alexandre Courbot [this message]
[not found] ` <54520CFE.9060907-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 10:18 ` Terje Bergström
[not found] ` <5452107D.8080207-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 10:22 ` Alexandre Courbot
[not found] ` <54521181.8080005-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 11:04 ` Terje Bergström
[not found] ` <54521B22.6070708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 13:35 ` Alexandre Courbot
[not found] ` <54523E8B.7000900-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 13:47 ` Terje Bergström
[not found] ` <5452418F.8080005-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-10-30 14:56 ` Thierry Reding
2014-10-13 10:33 ` [PATCH 06/12] ARM: tegra: Add memory controller support for Tegra20 Thierry Reding
[not found] ` <1413196434-5292-6-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-17 17:43 ` David Riley
[not found] ` <CAASgrz3Z2vW0L+u5kju9bAh-R4PnreMnhoGaKY_UwSTGFcBshA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 14:45 ` Thierry Reding
2014-10-13 10:33 ` [PATCH 07/12] ARM: tegra: Add memory controller support for Tegra30 Thierry Reding
2014-10-13 10:33 ` [PATCH 08/12] ARM: tegra: Add memory controller support for Tegra114 Thierry Reding
2014-10-13 10:33 ` [PATCH 09/12] ARM: tegra: Add memory controller support for Tegra124 Thierry Reding
2014-10-13 10:33 ` [PATCH 10/12] ARM: tegra: Enable IOMMU for display controllers on Tegra30 Thierry Reding
2014-10-13 10:33 ` [PATCH 11/12] ARM: tegra: Enable IOMMU for display controllers on Tegra114 Thierry Reding
2014-10-13 10:33 ` [PATCH 12/12] ARM: tegra: Enable IOMMU for display controllers on Tegra124 Thierry Reding
2014-10-20 11:02 ` [PATCH v3 01/12] clk: tegra: Implement memory-controller clock Tomeu Vizoso
[not found] ` <CAAObsKB0ozbOy8ZzgbEyf-SrqF5jpfHUXCJdAMiqgS78DAyaVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-30 14:57 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54520CFE.9060907@nvidia.com \
--to=acourbot-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).