From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Li, ZhenHua" Subject: Re: [PATCH 1/1] x86/iommu: fix incorrect bit operations in setting values Date: Fri, 14 Nov 2014 16:12:02 +0800 Message-ID: <5465B952.3010702@hp.com> References: <1415172619-4801-1-git-send-email-zhen-hual@hp.com> <20141112112832.GA3334@dhcp-17-108.nay.redhat.com> <546474AF.2030902@hp.com> <20141113133708.GA1678@dhcp-17-102.nay.redhat.com> <54655B0F.5070204@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54655B0F.5070204-VXdhtT5mjnY@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Baoquan He Cc: Minfei Huang , kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "Li, ZhenHua" , dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org List-Id: iommu@lists.linux-foundation.org > 1st step shows we should NOT disable the iommu when it is already > enabled. But current code does disable-enable. So there is still works > to do. > The original kernel does a disable and re-enable , Bill's patchset removed the disable operation. > I think step 2 is necessary, because when the driver initializes, the > device need a new map, and the old data from the old kernel can not be > used for the new driver. > > Now I am trying to implement these ideas. > >> Thanks