From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH] iommu: fix trace_map() to report original iova and original size Date: Mon, 19 Jan 2015 09:45:09 -0700 Message-ID: <54BD3495.7070501@osg.samsung.com> References: <1421375383-8930-1-git-send-email-shuahkh@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1421375383-8930-1-git-send-email-shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org, alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 01/15/2015 07:29 PM, Shuah Khan wrote: > iommu_map() calls trace_map() with iova and size. trace_map() > should report original iova and original size as opposed to > iova and size after they get changed during mapping. size is > always zero at the end of mapping which is useless to report > and iova as it gets incremented, it is not as useful as the > original iova. Change iommu_map() to call trace_map() to > report original iova and original size. > > Signed-off-by: Shuah Khan > Reported-by: Alex Williamson > --- > drivers/iommu/iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index f7718d7..fbf8827 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1084,7 +1084,7 @@ int iommu_map(struct iommu_domain *domain, unsigned long iova, > if (ret) > iommu_unmap(domain, orig_iova, orig_size - size); > else > - trace_map(iova, paddr, size); > + trace_map(orig_iova, paddr, orig_size); > > return ret; > } > Joerg, Just makeing sure you saw this as well. I saw your responses on the trace_unmap() patches that you pulled them in. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978