From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Medve Subject: Re: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* annotations Date: Fri, 30 Jan 2015 00:55:40 -0600 Message-ID: <54CB2AEC.9000800@Freescale.com> References: <1422455698-3074-1-git-send-email-Emilian.Medve@Freescale.com> <1422455698-3074-2-git-send-email-Emilian.Medve@Freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sethi Varun-B16395 , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" , "jroedel-l3A5Bk7waGM@public.gmane.org" List-Id: iommu@lists.linux-foundation.org Hello Varun, On 01/30/2015 12:46 AM, Sethi Varun-B16395 wrote: > Hi Emil, > >> -----Original Message----- >> From: Emil Medve [mailto:Emilian.Medve-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org] >> Sent: Wednesday, January 28, 2015 8:05 PM >> To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org; jroedel-l3A5Bk7waGM@public.gmane.org; >> Sethi Varun-B16395 >> Cc: Medve Emilian-EMMEDVE1 >> Subject: [PATCH v2 01/26] iommu/fsl: Sprinkle some __init* annotations >> >> Signed-off-by: Emil Medve >> --- >> drivers/iommu/fsl_pamu.c | 12 ++++++------ >> drivers/iommu/fsl_pamu_domain.c | 2 +- >> 2 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index >> d958e65..652c34d 100644 >> --- a/drivers/iommu/fsl_pamu.c >> +++ b/drivers/iommu/fsl_pamu.c >> @@ -50,7 +50,7 @@ struct pamu_isr_data { >> >> static struct paace *ppaact; >> static struct paace *spaact; >> -static struct ome *omt; >> +static struct ome *omt __initdata; > > [varun] omt shouldn't be initdata. It seems to be used only from probe()'s call tree: fsl_pamu_probe() and setup_omt(); both __init functions. Am I missing something? Cheers,