From: Marek Szyprowski <m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 2/4] iommu/exynos: Make driver depend on REGULATOR
Date: Tue, 03 Feb 2015 15:37:27 +0100 [thread overview]
Message-ID: <54D0DD27.5030000@samsung.com> (raw)
In-Reply-To: <1422316230-18893-3-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Hello,
On 2015-01-27 00:50, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
>
> When regulator is not selected during kconfig, linking of
> the exynos iommu driver fails due to missing symbols.
> Fix it!
Frankly, I never observed such issue. Could you provide the .config for
such case? I know that existing exynos iommu driver is broken, but
please, don't break it even more...
> Signed-off-by: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/iommu/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index dfa6cf1..2e6100d 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -190,7 +190,7 @@ config TEGRA_IOMMU_SMMU
>
> config EXYNOS_IOMMU
> bool "Exynos IOMMU Support"
> - depends on ARCH_EXYNOS && ARM
> + depends on ARCH_EXYNOS && ARM && REGULATOR
> select IOMMU_API
> select ARM_DMA_USE_IOMMU
> help
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2015-02-03 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 23:50 [PATCH 0/4] iommu: Small fixes and cleanups Joerg Roedel
2015-01-26 23:50 ` [PATCH 1/4] iommu: Make more drivers depend on COMPILE_TEST Joerg Roedel
2015-01-27 7:14 ` [PATCH 0/4] iommu: Small fixes and cleanups Laurent Pinchart
[not found] ` <1422316230-18893-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-01-26 23:50 ` [PATCH 2/4] iommu/exynos: Make driver depend on REGULATOR Joerg Roedel
[not found] ` <1422316230-18893-3-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-02-03 14:37 ` Marek Szyprowski [this message]
2015-02-04 15:25 ` Joerg Roedel
2015-01-26 23:50 ` [PATCH 3/4] iommu/omap: Print phys_addr_t using %pa Joerg Roedel
2015-01-26 23:50 ` [PATCH 4/4] iommu/fsl: Use %pa to print phys_addr_t Joerg Roedel
[not found] ` <1422316230-18893-5-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-01-27 10:40 ` Emil Medve
[not found] ` <54C76B23.3010809-eDlz3WWmN0ll57MIdRCFDg@public.gmane.org>
2015-01-27 11:08 ` Joerg Roedel
2015-01-30 13:30 ` [PATCH 0/4] iommu: Small fixes and cleanups Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D0DD27.5030000@samsung.com \
--to=m.szyprowski-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox