Linux IOMMU Development
 help / color / mirror / Atom feed
From: "Li, ZhenHua" <zhen-hual-VXdhtT5mjnY@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	tom.vaden-VXdhtT5mjnY@public.gmane.org,
	rwright-VXdhtT5mjnY@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lisa.mitchell-VXdhtT5mjnY@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	doug.hatch-VXdhtT5mjnY@public.gmane.org,
	ishii.hironobu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	billsumnerlinux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	li.zhang6-VXdhtT5mjnY@public.gmane.org,
	dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v9 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel
Date: Fri, 03 Apr 2015 15:54:07 +0800	[thread overview]
Message-ID: <551E471F.7090504@hp.com> (raw)
In-Reply-To: <20150402111133.GM4441-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>

Hi Joerg,
This is quite strange. I checked the patches from patch 01 to 10 using 
./scripts/checkpatch.pl under the kernel source directory, but got 0 
errors and 0 warning.  Only some white spaces in the cover letter 00, 
but is could not be checked by this script.

But I checked the intel-iommu.c using "checkpatch.pl -f", found too many 
warnings and errors. Maybe we need a new patch to fix them.

Thanks
Zhenhua

On 04/02/2015 07:11 PM, Joerg Roedel wrote:
> Hi Zhen-Hua,
>
> On Thu, Mar 19, 2015 at 01:36:18PM +0800, Li, Zhen-Hua wrote:
>> This patchset is an update of Bill Sumner's patchset, implements a fix for:
>> If a kernel boots with intel_iommu=on on a system that supports intel vt-d,
>> when a panic happens, the kdump kernel will boot with these faults:
>
> I reviewed this patch-set and it is getting closer to a point where it
> could be merged. I found a few white-space errors in the review, please
> do a check_patch run on the next round and fix these. Besides that and
> given some third-party testing and reviews I think we can look forward
> to merge it early after the merge-window for v4.1, to give it enough
> testing in -next too.
>
>
> 	Joerg
>

  parent reply	other threads:[~2015-04-03  7:54 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19  5:36 [PATCH v9 0/10] iommu/vt-d: Fix intel vt-d faults in kdump kernel Li, Zhen-Hua
     [not found] ` <1426743388-26908-1-git-send-email-zhen-hual-VXdhtT5mjnY@public.gmane.org>
2015-03-19  5:36   ` [PATCH v9 01/10] iommu/vt-d: New function to attach domain with id Li, Zhen-Hua
2015-03-19  5:36   ` [PATCH v9 02/10] iommu/vt-d: Items required for kdump Li, Zhen-Hua
2015-03-19  5:36   ` [PATCH v9 03/10] iommu/vt-d: Function to get old context entry Li, Zhen-Hua
2015-03-19  5:36   ` [PATCH v9 04/10] iommu/vt-d: functions to copy data from old mem Li, Zhen-Hua
2015-03-19  5:36   ` [PATCH v9 05/10] iommu/vt-d: Add functions to load and save old re Li, Zhen-Hua
2015-03-19  5:36   ` [PATCH v9 06/10] iommu/vt-d: datatypes and functions used for kdump Li, Zhen-Hua
2015-03-19  5:36   ` [PATCH v9 07/10] iommu/vt-d: enable kdump support in iommu module Li, Zhen-Hua
2015-04-02 11:06     ` Joerg Roedel
     [not found]       ` <20150402110608.GL4441-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-04-03  7:45         ` Li, ZhenHua
2015-03-19  5:36   ` [PATCH v9 08/10] iommu/vt-d: assign new page table for dma_map Li, Zhen-Hua
2015-03-19  5:36   ` [PATCH v9 09/10] iommu/vt-d: Copy functions for irte Li, Zhen-Hua
2015-03-19  5:36   ` [PATCH v9 10/10] iommu/vt-d: Use old irte in kdump kernel Li, Zhen-Hua
2015-04-02 11:11   ` [PATCH v9 0/10] iommu/vt-d: Fix intel vt-d faults " Joerg Roedel
     [not found]     ` <20150402111133.GM4441-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-04-03  7:54       ` Li, ZhenHua [this message]
2015-04-03  8:28 ` Dave Young
     [not found]   ` <20150403082816.GE22579-0VdLhd/A9PldIt/LePPtNh/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-04-03  8:31     ` Li, ZhenHua
2015-04-03  8:40 ` Dave Young
     [not found]   ` <20150403084031.GF22579-0VdLhd/A9PldIt/LePPtNh/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-04-03  9:01     ` Li, ZhenHua
2015-04-03  9:21       ` Dave Young
2015-04-03 14:05         ` Li, Zhen-Hua
2015-04-07  3:49           ` Dave Young
     [not found]         ` <20150403092111.GG22579-0VdLhd/A9PldIt/LePPtNh/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-04-05  1:54           ` Baoquan He
2015-04-07  3:46             ` Dave Young
2015-04-07  9:08               ` Dave Young
2015-04-07  9:55                 ` Li, ZhenHua
     [not found]                   ` <5523A977.1030707-VXdhtT5mjnY@public.gmane.org>
2015-04-08  3:33                     ` Dave Young
     [not found]               ` <20150407034622.GB7213-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-04-07 14:12                 ` Don Dutile
2015-05-07 14:00                   ` Dave Young
     [not found]                     ` <20150507140029.GC4559-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-05-07 14:25                       ` Don Dutile
2015-05-08  1:21                         ` Dave Young
     [not found]                           ` <20150508012118.GA4809-0VdLhd/A9PlTxLCkMk2GaBcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2015-05-10 21:37                             ` Don Dutile
2015-05-10 21:31                     ` Don Dutile
2015-05-04 11:05   ` Joerg Roedel
2015-05-04 15:21     ` Don Dutile
2015-05-05  6:09     ` Dave Young
     [not found]       ` <20150505060931.GB31063-0VdLhd/A9PlTxLCkMk2GaBcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2015-05-05 15:23         ` Joerg Roedel
2015-05-06  1:46           ` Dave Young
     [not found]             ` <20150506014649.GA14065-0VdLhd/A9PlTxLCkMk2GaBcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2015-05-06  8:16               ` Joerg Roedel
     [not found]                 ` <20150506081617.GB20611-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-05-07 13:25                   ` Dave Young
2015-05-07 13:56     ` Dave Young
2015-05-11 10:11       ` Joerg Roedel
2015-05-12  5:57         ` Dave Young
2015-05-12  6:41           ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551E471F.7090504@hp.com \
    --to=zhen-hual-vxdhtt5mjny@public.gmane.org \
    --cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=billsumnerlinux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=doug.hatch-VXdhtT5mjnY@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ishii.hironobu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=li.zhang6-VXdhtT5mjnY@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lisa.mitchell-VXdhtT5mjnY@public.gmane.org \
    --cc=rwright-VXdhtT5mjnY@public.gmane.org \
    --cc=tom.vaden-VXdhtT5mjnY@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox