From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH v6 10/25] iommu: exynos: remove useless device_add/remove callbacks Date: Mon, 18 May 2015 14:09:14 +0200 Message-ID: <5559D66A.5070406@samsung.com> References: <1430727380-10912-1-git-send-email-m.szyprowski@samsung.com> <1430727380-10912-11-git-send-email-m.szyprowski@samsung.com> <20150505145538.GL15736@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150505145538.GL15736-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: Thierry Reding , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shaik Ameer Basha , Joonyoung Shim , Arnd Bergmann , Rob Herring , Inki Dae , Seung-Woo Kim , Will Deacon , Tomasz Figa , linaro-mm-sig-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kukjin Kim , Laurent Pinchart , Kyungmin Park , Javier Martinez Canillas , Cho KyongHo , David Wodhouse , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hello, On 2015-05-05 16:55, Joerg Roedel wrote: > On Mon, May 04, 2015 at 10:16:05AM +0200, Marek Szyprowski wrote: >> The driver doesn't need to do anything important in device add/remove >> callbacks, because initialization will be done from device-tree specific >> callbacks added later. IOMMU groups created by current code were never >> used. > Hmm, will this remove support for iommu-groups in the exynos driver? I > am still working on the default-domain patch-set which makes iommu-group > support mandatory for iommu-drivers. I you wish, I can leave this code. iommu-groups were not used at all on Exynos, so I thought that there is no point keeping useless code. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland