From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH char-misc-next 10/19] lib: convert iova.c into a library Date: Tue, 28 Jul 2015 11:41:45 +0100 Message-ID: <55B75C69.30200@arm.com> References: <8131ebc8ecb5ef13ef0aa4c49dabe9694f0e410f.1438040669.git.ashutosh.dixit@intel.com> <20150728100340.GR10969@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150728100340.GR10969-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Ashutosh Dixit Cc: Greg Kroah-Hartman , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Anil S Keshavamurthy , Sudeep Dutt , Harish Chegondi , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Nikhil Rao , Andrew Morton , "David S. Miller" List-Id: iommu@lists.linux-foundation.org On 28/07/15 11:03, Joerg Roedel wrote: > On Mon, Jul 27, 2015 at 04:57:32PM -0700, Ashutosh Dixit wrote: >> From: Harish Chegondi >> >> This patch converts iova.c into a library, moving it from >> drivers/iommu/ to lib/, and exports its virtual address allocation and >> management functions so that other modules can reuse them. >> >> Cc: Joerg Roedel >> Reviewed-by: Anil S Keshavamurthy >> Reviewed-by: Sudeep Dutt >> Signed-off-by: Harish Chegondi > > Where is this going to be used outside of the IOMMU world? > ...and how does it relate to the patches from Sakari (+CC) doing much the same thing[1]? Having gone and fished out the main LKML thread ([2], to help anyone else missing it), I don't see any obvious dependency on the Intel IOMMU driver - what happens here if that is compiled out and hasn't called iommu_iova_cache_init() first? Robin. [1]:http://thread.gmane.org/gmane.linux.kernel.iommu/10142 [2]:http://thread.gmane.org/gmane.linux.kernel/2005895