From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer Date: Mon, 21 Sep 2015 11:32:15 +0200 Message-ID: <55FFCE9F.5090001@redhat.com> References: <1442586596-5920-1-git-send-email-feng.wu@intel.com> <1442586596-5920-13-git-send-email-feng.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Wu, Feng" , "alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" , "mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" List-Id: iommu@lists.linux-foundation.org On 21/09/2015 10:56, Wu, Feng wrote: > Hi Paolo & Alex, > > I find that there is a build error in the following two cases: > - KVM is configured as 'M' and VFIO as 'Y' > The reason is the build of irqbypass manager is triggered in > arch/x86/kvm/Makefile, and VFIO is built before KVM, hence > it cannot find the symbols in irqbypass manager. > > - Disable KVM and enable VFIO in .config > The reason is similar with the above one, the irqbypass manager > is not built since KVM is not configured. > > I think the point is that we cannot trigger the build of irqbypass > manager inside KVM or VFIO, we need trigger the build at a high > level and it should be built before VFIO and KVM. Any ideas? We can add virt/Makefile and build virt/lib/ directly, not through arch/x86/kvm. Paolo