iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Wu, Feng" <feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org"
	<joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
	"mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v9 00/18] Add VT-d Posted-Interrupts support - including prerequisite series
Date: Mon, 28 Sep 2015 12:18:35 +0200	[thread overview]
Message-ID: <560913FB.1070107@redhat.com> (raw)
In-Reply-To: <E959C4978C3B6342920538CF579893F009A56378-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>



On 28/09/2015 12:14, Wu, Feng wrote:
> Thanks a lot for creating branch for vt-d pi. However, I cannot launch guests
> with this tree. I encountered the following kernel dump, and I find that the
> problematic commit is " 2260b1cde0b5472ab70ad0764b10095372e41913 "
> 
>     KVM: x86: put vcpu_create under kvm->srcu critical section
> 
>     This is needed in case vcpu_create wants to access the memslots array.
>     Fixes this lockdep splat:
> 
> After removing this commit from the tree, my VT-d patch-set works fine.

Great, thanks.  The above commit had already been reverted.

I'm sorting out the kbuild reports, and then will merge VT-d PI.

Paolo

> 
> Kernel dump:
> [  221.978182] BUG: unable to handle kernel NULL pointer dereference at           (null)
> [  221.986085] IP: [<ffffffffc0368ab0>] kvm_arch_vcpu_create+0x30/0x90 [kvm]
> [  221.993102] PGD 0
> [  221.995148] Oops: 0000 [#1] SMP
> [  221.998440] Modules linked in: bnep rfcomm bluetooth ax88179_178a usbnet intel_rapl mii snd_hda_codec_hdmi iosf_mbi x86_pkg_temp_thermal nouveau intel_powerclamp snd_hda_intel snd_hda_codec coretemp kvm_intel snd_hda_core kvm snd_hwdep snd_pcm crct10dif_pclmul crc32_pclmul snd_seq_midi ghash_clmulni_intel mxm_wmi snd_seq_midi_event snd_rawmidi video snd_seq ttm aesni_intel aes_x86_64 lrw gf128mul drm_kms_helper snd_seq_device binfmt_misc snd_timer glue_helper ablk_helper drm cryptd fb_sys_fops snd syscopyarea sysfillrect sb_edac soundcore sysimgblt mei_me parport_pc edac_core ppdev mei shpchp lp lpc_ich mac_hid parport acpi_power_meter wmi ixgbe igb i2c_algo_bit hid_generic usbhid ptp ahci hid libahci pps_core mdio
> [  222.063533] CPU: 4 PID: 3384 Comm: qemu-system-x86 Not tainted 4.3.0-rc1+ #6
> [  222.070612] Hardware name: Intel Corp. GRANGEVILLE/GRANTLEY, BIOS GNVDCRB1.86B.0020.V07.1409241147 09/24/2014
> [  222.080764] task: ffff88006e7c8000 ti: ffff8800714a8000 task.ti: ffff8800714a8000
> [  222.088283] RIP: 0010:[<ffffffffc0368ab0>]  [<ffffffffc0368ab0>] kvm_arch_vcpu_create+0x30/0x90 [kvm]
> [  222.097680] RSP: 0018:ffff8800714abde0  EFLAGS: 00010246
> [  222.103153] RAX: 0000000000000000 RBX: ffff88016f28c000 RCX: 0000000000000000
> [  222.110407] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88016f28c000
> [  222.117659] RBP: ffff8800714abdf8 R08: 0000000000000001 R09: 0000000000000040
> [  222.124824] R10: ffff880077e86438 R11: ffff880163e06880 R12: ffff88016f28c000
> [  222.132150] R13: 0000000000000000 R14: 000000000000ae41 R15: 0000000000000000
> [  222.139405] FS:  00007f43fd7ec700(0000) GS:ffff880178700000(0000) knlGS:0000000000000000
> [  222.147629] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [  222.153471] CR2: 0000000000000000 CR3: 000000017074b000 CR4: 00000000003426e0
> [  222.160726] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [  222.167979] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [  222.175231] Stack:
> [  222.177277]  0000000000000000 ffff88016f28c000 0000000000000000 ffff8800714abea0
> [  222.184870]  ffffffffc0355b17 0000000000000008 ffff8800714abe28 ffffffff810aba32
> [  222.192444]  ffff880178816e40 ffff8800714abe40 ffffffff810a4f44 ffff880178816e40
> [  222.200017] Call Trace:
> [  222.202522]  [<ffffffffc0355b17>] kvm_vm_ioctl+0x277/0x6e0 [kvm]
> [  222.208633]  [<ffffffff810aba32>] ? put_prev_task_fair+0x22/0x40
> [  222.214741]  [<ffffffff810a4f44>] ? pick_next_task_idle+0x14/0x30
> [  222.220942]  [<ffffffff811fb53a>] do_vfs_ioctl+0x2ba/0x490
> [  222.226523]  [<ffffffff8106274a>] ? __do_page_fault+0x1ba/0x410
> [  222.232546]  [<ffffffff811fb789>] SyS_ioctl+0x79/0x90
> [  222.237684]  [<ffffffff81003ba5>] ? syscall_return_slowpath+0x55/0x150
> [  222.244323]  [<ffffffff81791d36>] entry_SYSCALL_64_fastpath+0x16/0x75
> [  222.250869] Code: 55 48 89 e5 41 55 41 54 53 41 89 f5 48 89 fb e8 27 61 cb c0 85 c0 74 13 8b 83 f0 09 00 00 85 c0 74 09 80 3d 53 2e 04 00 00 74 40 <48> 8b 04 25 00 00 00 00 48 8d 78 48 e8 7f c4 d6 c0 41 89 c4 48
> [  222.270790] RIP  [<ffffffffc0368ab0>] kvm_arch_vcpu_create+0x30/0x90 [kvm]
> [  222.277813]  RSP <ffff8800714abde0>
> [  222.281359] CR2: 0000000000000000
> [  222.290421] ---[ end trace 957f5a39692fe6c7 ]---
> root@feng-bdw-de-pi:~/workspace/tools# dmesg > ~/dmesg.log
> root@feng-bdw-de-pi:~/workspace/tools# vim ~/dmesg.log
> [  221.998440] Modules linked in: bnep rfcomm bluetooth ax88179_178a usbnet intel_rapl mii snd_hda_codec_hdmi iosf_mbi x86_pkg_temp_thermal nouveau intel_powerclamp snd_hda_intel snd_hda_codec coretemp kvm_intel snd_hda_core kvm snd_hwdep snd_pcm crct10dif_pclmul crc32_pclmul snd_seq_midi ghash_clmulni_intel mxm_wmi snd_seq_midi_event snd_rawmidi video snd_seq ttm aesni_intel aes_x86_64 lrw gf128mul drm_kms_helper snd_seq_device binfmt_misc snd_timer glue_helper ablk_helper drm cryptd fb_sys_fops snd syscopyarea sysfillrect sb_edac soundcore sysimgblt mei_me parport_pc edac_core ppdev mei shpchp lp lpc_ich mac_hid parport acpi_power_meter wmi ixgbe igb i2c_algo_bit hid_generic usbhid ptp ahci hid libahci pps_core mdio
> [  222.063533] CPU: 4 PID: 3384 Comm: qemu-system-x86 Not tainted 4.3.0-rc1+ #6
> [  222.070612] Hardware name: Intel Corp. GRANGEVILLE/GRANTLEY, BIOS GNVDCRB1.86B.0020.V07.1409241147 09/24/2014
> [  222.080764] task: ffff88006e7c8000 ti: ffff8800714a8000 task.ti: ffff8800714a8000
> [  222.088283] RIP: 0010:[<ffffffffc0368ab0>]  [<ffffffffc0368ab0>] kvm_arch_vcpu_create+0x30/0x90 [kvm]
> [  222.097680] RSP: 0018:ffff8800714abde0  EFLAGS: 00010246
> [  222.103153] RAX: 0000000000000000 RBX: ffff88016f28c000 RCX: 0000000000000000
> [  222.110407] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88016f28c000
> [  222.117659] RBP: ffff8800714abdf8 R08: 0000000000000001 R09: 0000000000000040
> [  222.124824] R10: ffff880077e86438 R11: ffff880163e06880 R12: ffff88016f28c000
> [  222.132150] R13: 0000000000000000 R14: 000000000000ae41 R15: 0000000000000000
> [  222.139405] FS:  00007f43fd7ec700(0000) GS:ffff880178700000(0000) knlGS:0000000000000000
> [  222.147629] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [  222.153471] CR2: 0000000000000000 CR3: 000000017074b000 CR4: 00000000003426e0
> [  222.160726] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [  222.167979] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [  222.175231] Stack:
> [  222.177277]  0000000000000000 ffff88016f28c000 0000000000000000 ffff8800714abea0
> [  222.184870]  ffffffffc0355b17 0000000000000008 ffff8800714abe28 ffffffff810aba32
> [  222.192444]  ffff880178816e40 ffff8800714abe40 ffffffff810a4f44 ffff880178816e40
> [  222.200017] Call Trace:
> [  222.202522]  [<ffffffffc0355b17>] kvm_vm_ioctl+0x277/0x6e0 [kvm]
> [  222.208633]  [<ffffffff810aba32>] ? put_prev_task_fair+0x22/0x40
> [  222.214741]  [<ffffffff810a4f44>] ? pick_next_task_idle+0x14/0x30
> [  222.220942]  [<ffffffff811fb53a>] do_vfs_ioctl+0x2ba/0x490
> [  222.226523]  [<ffffffff8106274a>] ? __do_page_fault+0x1ba/0x410
> [  222.232546]  [<ffffffff811fb789>] SyS_ioctl+0x79/0x90
> [  222.237684]  [<ffffffff81003ba5>] ? syscall_return_slowpath+0x55/0x150
> [  222.244323]  [<ffffffff81791d36>] entry_SYSCALL_64_fastpath+0x16/0x75
> [  222.250869] Code: 55 48 89 e5 41 55 41 54 53 41 89 f5 48 89 fb e8 27 61 cb c0 85 c0 74 13 8b 83 f0 09 00 00 85 c0 74 09 80 3d 53 2e 04 00 00 74 40 <48> 8b 04 25 00 00 00 00 48 8d 78 48 e8 7f c4 d6 c0 41 89 c4 48
> [  222.270790] RIP  [<ffffffffc0368ab0>] kvm_arch_vcpu_create+0x30/0x90 [kvm]
> [  222.277813]  RSP <ffff8800714abde0>
> [  222.281359] CR2: 0000000000000000
> [  222.290421] ---[ end trace 957f5a39692fe6c7 ]---

  parent reply	other threads:[~2015-09-28 10:18 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 14:29 [PATCH v9 00/18] Add VT-d Posted-Interrupts support - including prerequisite series Feng Wu
2015-09-18 14:29 ` [PATCH v9 03/18] KVM: arm/arm64: select IRQ_BYPASS_MANAGER Feng Wu
2015-09-21 19:32   ` Eric Auger
2015-09-18 14:29 ` [PATCH v9 08/18] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2015-09-18 14:29 ` [PATCH v9 10/18] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
     [not found] ` <1442586596-5920-1-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-18 14:29   ` [PATCH v9 01/18] virt: IRQ bypass manager Feng Wu
     [not found]     ` <1442586596-5920-2-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-18 15:34       ` Wu, Feng
2015-09-18 14:29   ` [PATCH v9 02/18] KVM: x86: select IRQ_BYPASS_MANAGER Feng Wu
2015-09-18 14:29   ` [PATCH v9 04/18] KVM: create kvm_irqfd.h Feng Wu
     [not found]     ` <1442586596-5920-5-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-18 15:35       ` Wu, Feng
2015-09-18 14:29   ` [PATCH v9 05/18] KVM: introduce kvm_arch functions for IRQ bypass Feng Wu
2015-09-18 14:29   ` [PATCH v9 06/18] KVM: eventfd: add irq bypass consumer management Feng Wu
2015-09-18 14:29   ` [PATCH v9 07/18] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu
2015-09-18 14:29   ` [PATCH v9 09/18] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu
2015-09-18 14:29   ` [PATCH v9 11/18] KVM: make kvm_set_msi_irq() public Feng Wu
2015-09-18 14:29   ` [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer Feng Wu
     [not found]     ` <1442586596-5920-13-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-18 17:19       ` Alex Williamson
2015-09-21  8:56       ` Wu, Feng
     [not found]         ` <E959C4978C3B6342920538CF579893F00272346C-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-21  9:32           ` Paolo Bonzini
     [not found]             ` <55FFCE9F.5090001-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-21 11:35               ` Wu, Feng
     [not found]                 ` <E959C4978C3B6342920538CF579893F002723C42-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-21 12:06                   ` Paolo Bonzini
     [not found]                     ` <55FFF2CC.6040107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-21 12:08                       ` Wu, Feng
2015-09-21 12:53               ` Wu, Feng
2015-09-21 13:02                 ` Paolo Bonzini
     [not found]                   ` <55FFFFEE.6090800-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-21 19:46                     ` Eric Auger
2016-04-26 20:08       ` Alex Williamson
     [not found]         ` <20160426140816.67b8b37c-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org>
2016-04-27  1:32           ` Wu, Feng
     [not found]             ` <E959C4978C3B6342920538CF579893F00C3D3D29-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-04-28 16:40               ` Alex Williamson
2016-04-28 15:35           ` Eric Auger
2015-09-18 14:29   ` [PATCH v9 13/18] KVM: x86: Update IRTE for posted-interrupts Feng Wu
2015-09-18 14:29   ` [PATCH v9 14/18] KVM: Implement IRQ bypass consumer callbacks for x86 Feng Wu
2015-09-18 14:29   ` [PATCH v9 15/18] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu
2015-09-18 14:29   ` [PATCH v9 16/18] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu
2015-09-18 14:29   ` [PATCH v9 17/18] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
     [not found]     ` <1442586596-5920-18-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-18 16:06       ` Paolo Bonzini
     [not found]         ` <55FC3690.3050905-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-19  7:11           ` Wu, Feng
2015-09-21  2:16         ` Wu, Feng
     [not found]           ` <E959C4978C3B6342920538CF579893F0027228E2-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-21  5:32             ` Paolo Bonzini
     [not found]               ` <55FF968A.6000509-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-21  5:45                 ` Wu, Feng
2015-10-14 23:41     ` David Matlack
     [not found]       ` <CALzav=f8KhXswW-FCuKOYmWoih3QM3HMFHkGmQ3q9mnLoqg+hA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-15  1:33         ` Wu, Feng
2015-10-15 17:39           ` David Matlack
     [not found]             ` <CALzav=d62jW7ZY3wn_-u6uhfvFXtCsvS_UoK2TPyZMvp=OPJpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-15 18:13               ` Paolo Bonzini
     [not found]                 ` <561FECB7.6080503-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-16  1:45                   ` Wu, Feng
2015-09-18 14:29   ` [PATCH v9 18/18] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu
     [not found]     ` <1442586596-5920-19-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-21 13:46       ` Joerg Roedel
2015-09-18 14:58   ` [PATCH v9 00/18] Add VT-d Posted-Interrupts support - including prerequisite series Paolo Bonzini
     [not found]     ` <55FC2699.10608-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-18 15:08       ` Wu, Feng
     [not found]         ` <E959C4978C3B6342920538CF579893F00271CB9C-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-18 15:21           ` Paolo Bonzini
2015-09-18 15:38             ` Wu, Feng
2015-09-18 17:57       ` Alex Williamson
2015-09-25  1:49   ` Wu, Feng
     [not found]     ` <E959C4978C3B6342920538CF579893F009A46D3D-zVW8+lm/ZpmiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-25 11:14       ` Paolo Bonzini
     [not found]         ` <56052C96.7070805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-28 10:14           ` Wu, Feng
     [not found]             ` <E959C4978C3B6342920538CF579893F009A56378-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-28 10:18               ` Paolo Bonzini [this message]
     [not found]                 ` <560913FB.1070107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-28 10:22                   ` Wu, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560913FB.1070107@redhat.com \
    --to=pbonzini-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).