Re: [PATCH V2 1/3] Docs: dt: rockchip: add rk-iommu, disable-reset-quirk property

Heiko Stuebner
2017-07-21T06:57:24Z

Hi Simon,

Am Freitag, 21. Juli 2017, 14:27:08 CEST schrieb Simon Xue:
> From: Simon <xxm-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> Add rk-iommu,disable-reset-quirk property to ignore the isp mmu
> reset operation
>
> Signed-off-by: Simon <xxm-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

please use your full name in From and Signed-off.

Also, you need to include devicetree-people and mailinglists (as
scripts/get_maintainer.pl will show you) when sending dt-binding
changes.

> ---
> changes since V1:
> - new added file
>
> Documentation/devicetree/bindings/iommu/rockchip,iommu.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt
> index 9a55ac3..aa2136c 100644
> --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt
> +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt
> @@ -15,6 +15,11 @@ Required properties:
> to associate with its master device. See:
> Documentation/devicetree/bindings/iommu/iommu.txt
>
> +Optional properties:
> +- rk-iommu,disable-reset-quirk : This ignore the isp mmu reset operation.

Prefix should be "rockchip," not "rk-iommu,".

Also, this quirk could be renamed to something like:

rockchip,disable-mmu-reset: Don't use the mmu reset operation.
Some mmu instances may produce unexpected results
when the reset operation is used.

But that is more a

Heiko

> + It can't get the expected result when isp mmu
> + reset, but the reset function work normally
> +
> Example:
>
> vopl_mmu: iommu@ff940300 {
>