From: Robin Murphy <robin.murphy@arm.com>
To: Anup Patel <anup.patel@broadcom.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>,
Robin Murphy <Robin.Murphy@arm.com>,
Sricharan R <sricharan@codeaurora.org>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Device Tree <devicetree@vger.kernel.org>,
Scott Branden <sbranden@broadcom.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Ray Jui <rjui@broadcom.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Vikram Prakash <vikramp@broadcom.com>,
Rob Herring <robh+dt@kernel.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [RFC PATCH 3/6] of: iommu: Increment DT node refcount in of_iommu_set_ops()
Date: Thu, 28 Jan 2016 17:15:23 +0000 [thread overview]
Message-ID: <56AA4CAB.6000708@arm.com> (raw)
In-Reply-To: <1453872079-27140-4-git-send-email-anup.patel@broadcom.com>
On 27/01/16 05:21, Anup Patel wrote:
> We are saving pointer to iommu DT node in of_iommu_set_ops()
> hence we should increment DT node ref count.
Oh man, shame on whoever wrote that code! :P
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Anup Patel <anup.patel@broadcom.com>
> Reviewed-by: Ray Jui <rjui@broadcom.com>
> Reviewed-by: Scott Branden <sbranden@broadcom.com>
> ---
> drivers/iommu/of_iommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
> index 60ba238..5fea665 100644
> --- a/drivers/iommu/of_iommu.c
> +++ b/drivers/iommu/of_iommu.c
> @@ -110,6 +110,7 @@ void of_iommu_set_ops(struct device_node *np, struct iommu_ops *ops)
> if (WARN_ON(!iommu))
> return;
>
> + of_node_get(np);
> INIT_LIST_HEAD(&iommu->list);
> iommu->np = np;
> iommu->ops = ops;
>
next prev parent reply other threads:[~2016-01-28 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 5:21 [RFC PATCH 0/6] iommu/arm-smmu: Add support for DMA domains and instruction fetch Anup Patel
[not found] ` <1453872079-27140-1-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-01-27 5:21 ` [RFC PATCH 1/6] iommu/arm-smmu: Init driver using IOMMU_OF_DECLARE Anup Patel
2016-01-27 5:21 ` [RFC PATCH 2/6] iommu/arm-smmu: Invoke DT probe from arm_smmu_of_setup() Anup Patel
2016-01-27 5:21 ` [RFC PATCH 3/6] of: iommu: Increment DT node refcount in of_iommu_set_ops() Anup Patel
2016-01-28 17:15 ` Robin Murphy [this message]
2016-01-27 5:21 ` [RFC PATCH 4/6] iommu/arm-smmu: Add support for IOMMU_DOMAIN_DMA in SMMUv1/SMMUv2 driver Anup Patel
[not found] ` <1453872079-27140-5-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-01-28 17:28 ` Robin Murphy
2016-01-28 17:48 ` Mark Rutland
[not found] ` <56AA4FBE.6090702-5wv7dgnIgG8@public.gmane.org>
2016-01-29 3:58 ` Anup Patel
2016-01-27 5:21 ` [RFC PATCH 5/6] iommu/arm-smmu: Option to treat instruction fetch as data read for SMMUv2 Anup Patel
[not found] ` <1453872079-27140-6-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-01-28 17:10 ` Robin Murphy
[not found] ` <56AA4B89.3040400-5wv7dgnIgG8@public.gmane.org>
2016-01-29 3:42 ` Anup Patel
2016-01-27 5:21 ` [RFC PATCH 6/6] iommu/arm-smmu: Update bindings document for smmu-inst-as-data DT option Anup Patel
[not found] ` <1453872079-27140-7-git-send-email-anup.patel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-01-27 12:28 ` Mark Rutland
2016-01-27 14:22 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA4CAB.6000708@arm.com \
--to=robin.murphy@arm.com \
--cc=anup.patel@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=sricharan@codeaurora.org \
--cc=vikramp@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).