From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Auger Subject: Re: [RFC v3 07/15] iommu: iommu_get/put_single_reserved Date: Thu, 18 Feb 2016 17:42:26 +0100 Message-ID: <56C5F472.1020003@linaro.org> References: <1455264797-2334-1-git-send-email-eric.auger@linaro.org> <1455264797-2334-8-git-send-email-eric.auger@linaro.org> <20160218110616.05108071@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160218110616.05108071@arm.com> Sender: kvm-owner@vger.kernel.org To: Marc Zyngier Cc: eric.auger@st.com, alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, christoffer.dall@linaro.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, suravee.suthikulpanit@amd.com, patches@linaro.org, linux-kernel@vger.kernel.org, Manish.Jaggi@caviumnetworks.com, Bharat.Bhushan@freescale.com, pranav.sawargaonkar@gmail.com, p.fedin@samsung.com, iommu@lists.linux-foundation.org, sherry.hurwitz@amd.com, brijesh.singh@amd.com, leo.duran@amd.com, Thomas.Lendacky@amd.com List-Id: iommu@lists.linux-foundation.org Hello, On 02/18/2016 12:06 PM, Marc Zyngier wrote: > On Fri, 12 Feb 2016 08:13:09 +0000 > Eric Auger wrote: > >> This patch introduces iommu_get/put_single_reserved. >> >> iommu_get_single_reserved allows to allocate a new reserved iova page >> and map it onto the physical page that contains a given physical address. >> It returns the iova that is mapped onto the provided physical address. >> Hence the physical address passed in argument does not need to be aligned. >> >> In case a mapping already exists between both pages, the IOVA mapped >> to the PA is directly returned. >> >> Each time an iova is successfully returned a binding ref count is >> incremented. >> >> iommu_put_single_reserved decrements the ref count and when this latter >> is null, the mapping is destroyed and the iova is released. > > I wonder if there is a requirement for the caller to find out about the > size of the mapping, or to impose a given size... MSIs clearly do not > have that requirement (this is always a 32bit value), but since. > allocations usually pair address and size, I though I'd ask... Yes. Currently this only makes sure the host PA is mapped and returns the corresponding IOVA. It is part of the discussion we need to have on the API besides the problematic of which API it should belong to. Thanks Eric > > Thanks, > > M. >