From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Date: Mon, 14 Mar 2016 20:37:02 +0700 Message-ID: <56E6BE7E.8010807@amd.com> References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> <20160314095856.GL6344@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160314095856.GL6344-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Peter Zijlstra Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, andihartmann-KuiJ5kEpwI6ELgA04lAiVw@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, labbott-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi, On 3/14/16 16:58, Peter Zijlstra wrote: > On Mon, Mar 14, 2016 at 12:26:00PM +0700, Suravee Suthikulpanit wrote: >> Hi, >> >> On 03/12/2016 08:22 PM, Peter Zijlstra wrote: >>> On Tue, Feb 23, 2016 at 08:12:36AM -0600, Suravee Suthikulpanit wrote: >>>> From: Suravee Suthikulpanit >>>> >>>> First, this patch move arch/x86/events/amd/iommu.h to >>>> arch/x86/include/asm/perf/amd/iommu.h so that we easily include >>>> it in both perf-amd-iommu and amd-iommu drivers. >>>> >>>> Then, we consolidate declaration of AMD IOMMU performance counter >>>> APIs into one file. >>> >>> These seem two independent thingies; should this therefore not be 2 >>> patches? >>> >>>> Reviewed-by: Joerg Roedel >>>> Signed-off-by: Suravee Suthikulpanit >>>> --- >>>> arch/x86/events/amd/iommu.c | 2 +- >>>> arch/x86/events/amd/iommu.h | 40 --------------------------------- >>>> arch/x86/include/asm/perf/amd/iommu.h | 42 +++++++++++++++++++++++++++++++++++ >>> >>> That seems somewhat excessive. Not only do you create >>> arch/x86/include/asm/perf/ you then put another directory on top of >>> that. >>> >> >> The original header files (arch/x86/events/amd/iommu.h and >> drivers/iommu/amd_iommu_proto.h) has duplicate function declarations. So, >> with the new header file being in the arch/x86/include/asm/perf/amd/iommu.h, >> we can just have one function declaration. >> >> So, you just want to separate the file moving part and the part that removes >> of the duplication? > > I'm fine with a new header, it just seems putting it in a two deep > direcotry hierarchy of its own that seems excessive. > Basically, we are trying to match the current Perf hierarchy for AMD IOMMU (arch/x86/events/amd/iommu.c). I can put it into arch/x86/include/asm/perf_amd_iommu.h. What would you prefer? Thanks, Suravee