Re: [PATCH v2 02/13] iommu/rockchip: Suppress unbinding

JeffyChen
2018-01-17T07:16:38Z

Hi Tomasz,

On 01/17/2018 01:32 PM, Tomasz Figa wrote:
> On Wed, Jan 17, 2018 at 1:23 PM, Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
>> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote:
>>> It's not safe to unbind rockchip IOMMU driver.
>>
>> Might be good to explain why it is not safe and actually add that it
>> does not make any sense for such low level devices.
>
> Actually, shouldn't we also remove support for .remove() and module
> exit? I don't think it's actually feasible to unload this driver. We
> actually even have ROCKCHIP_IOMMU Kconfig entry defined as bool, so
> the driver can be only built-in.
>
right, will do it in the next version.
> Best regards,
> Tomasz
>
>
>