From mboxrd@z Thu Jan 1 00:00:00 1970 From: JeffyChen Subject: Re: [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically Date: Wed, 17 Jan 2018 15:47:47 +0800 Message-ID: <5A5EFFA3.6070206@rock-chips.com> References: <20180116132540.18939-1-jeffy.chen@rock-chips.com> <20180116132540.18939-12-jeffy.chen@rock-chips.com> <5A5EF94E.7010806@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tomasz Figa Cc: Heiko Stuebner , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ricky Liang , "open list:ARM/Rockchip SoC..." , "list-Y9sIeH5OGRo@public.gmane.org:IOMMU DRIVERS" , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 01/17/2018 03:30 PM, Tomasz Figa wrote: >> >but it's possible the probe failed after calling iommu_device_set_fwnode, so >> >i'll try to add some checks here, and maybe adjust probe() to prevent it >> >too. > I think iommu_device_set_fwnode() is not enough for of_iommu_xlate() > to find the IOMMU. The IOMMU is actually added to the IOMMU list by > iommu_device_register(), which is last in the sequence, so I guess we > should be fine. > hmmm, the later patch would change that ;) i'll fix it in the next version. > Best regards, > Tomasz > > >