From: Baolu Lu <baolu.lu@linux.intel.com>
To: Vasant Hegde <vasant.hegde@amd.com>,
iommu@lists.linux.dev, joro@8bytes.org
Cc: baolu.lu@linux.intel.com, suravee.suthikulpanit@amd.com,
Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
Subject: Re: [PATCH iommu/next] iommu: Fix default domain setup
Date: Tue, 20 Jun 2023 13:12:21 +0800 [thread overview]
Message-ID: <5b4f9e9a-ef97-94c4-ba3f-364b5ba30eff@linux.intel.com> (raw)
In-Reply-To: <358def2d-163d-ea57-c0c7-6d4affc68d0d@amd.com>
On 6/19/23 2:49 PM, Vasant Hegde wrote:
>>> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
>>> index 9e0228ef612b..d21d0a217bdf 100644
>>> --- a/drivers/iommu/iommu.c
>>> +++ b/drivers/iommu/iommu.c
>>> @@ -2880,7 +2880,6 @@ static int iommu_setup_default_domain(struct iommu_group
>>> *group,
>>> }
>>> /* We must set default_domain early for __iommu_device_set_domain */
>> Is the above comment still relevant? If yes, this fix seems to be
>> problematic. Or no?
> I think we should keep below change.
If the change is necessary then we should remove above comment with
sufficient justification.
Best regards,
baolu
prev parent reply other threads:[~2023-06-20 5:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 5:56 [PATCH iommu/next] iommu: Fix default domain setup Vasant Hegde
2023-06-14 6:27 ` Baolu Lu
2023-06-19 6:49 ` Vasant Hegde
2023-06-20 5:12 ` Baolu Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b4f9e9a-ef97-94c4-ba3f-364b5ba30eff@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dheerajkumar.srivastava@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox