From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D0AC32792 for ; Thu, 3 Oct 2019 16:11:21 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9F832054F for ; Thu, 3 Oct 2019 16:11:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Pq/jSr1x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9F832054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 8F6301009; Thu, 3 Oct 2019 16:11:20 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 734FFFCD for ; Thu, 3 Oct 2019 16:11:19 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0829A19B for ; Thu, 3 Oct 2019 16:11:18 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id q7so2058397pfh.8 for ; Thu, 03 Oct 2019 09:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:from:to:cc:subject:user-agent:date; bh=WCl0BJ/xg5z2POfrHRFKcHi5xkDivkEW/iGK30/2GP0=; b=Pq/jSr1xmzlqjDuxBQh7dFDV5hRyr6MZtXVubXctjAF8kRjt+U6xL1O1zUsbiV9qug ygNsoBsTe8l9J4vQh++/GIEgBZ3tc+dCBa+tnW6tuf4O22v4fqwHlcvMDTQXutYl4bj7 bWJISwhs7L3e2klQ4E9mPH1vemoDoOFTbhMxY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:from:to:cc:subject :user-agent:date; bh=WCl0BJ/xg5z2POfrHRFKcHi5xkDivkEW/iGK30/2GP0=; b=OUN8agJ3l706MSE4Xeplcq0YgarGqGyp8xQmGuIbhdYG57CJ9O3MD+WE/NRZwID2nV LR0UjoafSRi/2/LG25P95pmYNHnWYaCZWNFbdMqSB+FSsqY+cnhZW6M6CJ6ypAbKbhHK mXpGCq3+QIlRzJCF9RrNxNVg1+cX7Er49fe5vxE5qKYXQ23Pvh90YvLLv4C2IrzCxTxS LxcDYfNb/FAdPByxXK8Q7LzX3EnjI9pIqu2U1h97KwbFy+Lpwel4izWm3nYl7DOYjJ38 Y4z+RljmmE93nWMxHHXnMNClaPkBDDxd+D7XLbQn7WTrI+8RXNlY1bWD1QC8FLSTorUU drVA== X-Gm-Message-State: APjAAAUMysS1dgPCuaGoHswjQRAwz/x1lcwhShAdcrrg4Tzhdx+yMqFm 4F8QuV3z95MIERJQpeLrkwEl3Q== X-Google-Smtp-Source: APXvYqwgRSbE1eF4YKGVz+xu6rX+ntZRdmjPXT4BO1EQpfB2LWEVRFrJK7RpkgO+T9w/1Sx9rAIAHg== X-Received: by 2002:a17:90a:ba94:: with SMTP id t20mr11602435pjr.8.1570119078443; Thu, 03 Oct 2019 09:11:18 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id j25sm4527578pfi.113.2019.10.03.09.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 09:11:17 -0700 (PDT) Message-ID: <5d961da5.1c69fb81.f4dce.d93e@mx.google.com> MIME-Version: 1.0 In-Reply-To: <20191001180622.806-1-geert+renesas@glider.be> References: <20191001180622.806-1-geert+renesas@glider.be> From: Stephen Boyd To: Geert Uytterhoeven , Joerg Roedel Subject: Re: [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory User-Agent: alot/0.8.1 Date: Thu, 03 Oct 2019 09:11:17 -0700 Cc: linux-renesas-soc@vger.kernel.org, Greg Kroah-Hartman , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Quoting Geert Uytterhoeven (2019-10-01 11:06:22) > As platform_get_irq() now prints an error when the interrupt does not > exist, calling it gratuitously causes scary messages like: > > ipmmu-vmsa e6740000.mmu: IRQ index 0 not found > > Fix this by moving the call to platform_get_irq() down, where the > existence of the interrupt is mandatory. > > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()") > Signed-off-by: Geert Uytterhoeven > --- Reviewed-by: Stephen Boyd _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu