From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Xuchun Shang <xuchun.shang@linux.alibaba.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
iommu@lists.linux.dev
Subject: Re: [PATCH] iommu/vt-d: fix wrong use of pasid config
Date: Tue, 9 Apr 2024 08:58:48 -0400 [thread overview]
Message-ID: <5e29fc2d-0f75-4929-af74-224c5f891c2f@linux.intel.com> (raw)
In-Reply-To: <20240401060753.3321318-1-xuchun.shang@linux.alibaba.com>
On 2024-04-01 2:07 a.m., Xuchun Shang wrote:
> The commit "iommu/vt-d: Add IOMMU perfmon support" introduce IOMMU
> PMU feature, but use the wrong config when set pasid filter.
>
> Fixes: 7232ab8b89e9 ("iommu/vt-d: Add IOMMU perfmon support")
> Signed-off-by: Xuchun Shang <xuchun.shang@linux.alibaba.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> ---
> drivers/iommu/intel/perfmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel/perfmon.c b/drivers/iommu/intel/perfmon.c
> index cf43e798eca4..44083d01852d 100644
> --- a/drivers/iommu/intel/perfmon.c
> +++ b/drivers/iommu/intel/perfmon.c
> @@ -438,7 +438,7 @@ static int iommu_pmu_assign_event(struct iommu_pmu *iommu_pmu,
> iommu_pmu_set_filter(domain, event->attr.config1,
> IOMMU_PMU_FILTER_DOMAIN, idx,
> event->attr.config1);
> - iommu_pmu_set_filter(pasid, event->attr.config1,
> + iommu_pmu_set_filter(pasid, event->attr.config2,
> IOMMU_PMU_FILTER_PASID, idx,
> event->attr.config1);
> iommu_pmu_set_filter(ats, event->attr.config2,
next prev parent reply other threads:[~2024-04-09 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 6:07 [PATCH] iommu/vt-d: fix wrong use of pasid config Xuchun Shang
2024-04-09 12:58 ` Liang, Kan [this message]
2024-04-11 2:50 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e29fc2d-0f75-4929-af74-224c5f891c2f@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=will@kernel.org \
--cc=xuchun.shang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox