From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC948CCA47B for ; Tue, 14 Jun 2022 02:21:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9CE9940484; Tue, 14 Jun 2022 02:21:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ENV_Sp0HfZD; Tue, 14 Jun 2022 02:21:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 71B8940320; Tue, 14 Jun 2022 02:21:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1C357C0032; Tue, 14 Jun 2022 02:21:38 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 59CFAC002D for ; Tue, 14 Jun 2022 02:21:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 32BC482871 for ; Tue, 14 Jun 2022 02:21:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wm2BRrO7mhts for ; Tue, 14 Jun 2022 02:21:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by smtp1.osuosl.org (Postfix) with ESMTPS id 90D698276E for ; Tue, 14 Jun 2022 02:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655173294; x=1686709294; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=IztUUoy8U8XG/s2pBKQMDOQCni2K/ES1DelQBEeR07o=; b=T7onGVryalr23E00KRelL541sYFiPEQVbI5RtqsSJawkcFBsRXE7h7O/ DbDxLXLBd6kWIrBVTWWWmSucyxcegVdOYbrPkdKQFWOwokLBk0eONsTQI oplGz+vuZDZWNkhaQSdP4CiD9ulXS+V06i1jSErRIyhJub7RmrOrvV1de vMwtC60F8b9lf7Rl6Gifl0UjANzGTY8aF/ZUctfq98S+b61LH9DHJZ+eA 3psBw8S5jHCT8iaqsPduwyKya8e5VBfLyKM7X+m0+bREV5O2BPHUjqWYM EYa62VaphCAnZppD/jmzPCR7+tlTCwJNw91SbqaP/uOO91M2OAdLL+2h/ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="258306452" X-IronPort-AV: E=Sophos;i="5.91,298,1647327600"; d="scan'208";a="258306452" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 19:21:34 -0700 X-IronPort-AV: E=Sophos;i="5.91,298,1647327600"; d="scan'208";a="910710180" Received: from gren5-mobl1.ccr.corp.intel.com (HELO [10.255.29.39]) ([10.255.29.39]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 19:21:31 -0700 Message-ID: <616dc81c-dfc6-d6c6-1eab-de0e9ba4411f@linux.intel.com> Date: Tue, 14 Jun 2022 10:21:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting Content-Language: en-US To: Jerry Snitselaar References: <20220505194658.246121-1-steve.wahl@hpe.com> <20220512151309.330068-1-steve.wahl@hpe.com> <20220613205734.3x7i46bnsofzerr4@cantor> <673eb011-94f4-46b0-f1b4-24a02a269f4e@linux.intel.com> <9c943703-0c2f-b654-a28b-f594bf90bec9@linux.intel.com> From: Baolu Lu In-Reply-To: Cc: Dimitri Sivanich , Joerg Roedel , Russ Anderson , Steve Wahl , Mike Travis , David Woodhouse , Kyung Min Park , Linux List Kernel Mailing , iommu , Will Deacon X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2022/6/14 09:54, Jerry Snitselaar wrote: > On Mon, Jun 13, 2022 at 6:51 PM Baolu Lu wrote: >> >> On 2022/6/14 09:44, Jerry Snitselaar wrote: >>> On Mon, Jun 13, 2022 at 6:36 PM Baolu Lu wrote: >>>> On 2022/6/14 04:57, Jerry Snitselaar wrote: >>>>> On Thu, May 12, 2022 at 10:13:09AM -0500, Steve Wahl wrote: >>>>>> To support up to 64 sockets with 10 DMAR units each (640), make the >>>>>> value of DMAR_UNITS_SUPPORTED adjustable by a config variable, >>>>>> CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is >>>>>> set. >>>>>> >>>>>> If the available hardware exceeds DMAR_UNITS_SUPPORTED (previously set >>>>>> to MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to >>>>>> allocate seq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ >>>>>> remapping doesn't support X2APIC mode x2apic disabled"; and the system >>>>>> fails to boot properly. >>>>>> >>>>>> Signed-off-by: Steve Wahl >>>>>> --- >>>>>> >>>>>> Note that we could not find a reason for connecting >>>>>> DMAR_UNITS_SUPPORTED to MAX_IO_APICS as was done previously. Perhaps >>>>>> it seemed like the two would continue to match on earlier processors. >>>>>> There doesn't appear to be kernel code that assumes that the value of >>>>>> one is related to the other. >>>>>> >>>>>> v2: Make this value a config option, rather than a fixed constant. The default >>>>>> values should match previous configuration except in the MAXSMP case. Keeping the >>>>>> value at a power of two was requested by Kevin Tian. >>>>>> >>>>>> drivers/iommu/intel/Kconfig | 6 ++++++ >>>>>> include/linux/dmar.h | 6 +----- >>>>>> 2 files changed, 7 insertions(+), 5 deletions(-) >>>>>> >>>>>> diff --git a/drivers/iommu/intel/Kconfig b/drivers/iommu/intel/Kconfig >>>>>> index 247d0f2d5fdf..fdbda77ac21e 100644 >>>>>> --- a/drivers/iommu/intel/Kconfig >>>>>> +++ b/drivers/iommu/intel/Kconfig >>>>>> @@ -9,6 +9,12 @@ config DMAR_PERF >>>>>> config DMAR_DEBUG >>>>>> bool >>>>>> >>>>>> +config DMAR_UNITS_SUPPORTED >>>>>> + int "Number of DMA Remapping Units supported" >>>>> Also, should there be a "depends on (X86 || IA64)" here? >>>> Do you have any compilation errors or warnings? >>>> >>>> Best regards, >>>> baolu >>>> >>> I think it is probably harmless since it doesn't get used elsewhere, >>> but our tooling was complaining to me because DMAR_UNITS_SUPPORTED was >>> being autogenerated into the configs for the non-x86 architectures we >>> build (aarch64, s390x, ppcle64). >>> We have files corresponding to the config options that it looks at, >>> and I had one for x86 and not the others so it noticed the >>> discrepancy. >> >> So with "depends on (X86 || IA64)", that tool doesn't complain anymore, >> right? >> >> Best regards, >> baolu >> > > Yes, with the depends it no longer happens. The dmar code only exists on X86 and IA64 arch's. Adding this depending makes sense to me. I will add it if no objections. Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu