From: Robin Murphy <robin.murphy@arm.com>
To: David Stevens <stevensd@chromium.org>, Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Tom Murphy <murphyt7@tcd.ie>
Subject: Re: [PATCH v3 4/5] dma-iommu: Check CONFIG_SWIOTLB more broadly
Date: Wed, 11 Aug 2021 20:02:15 +0100 [thread overview]
Message-ID: <681553ad-df37-a469-8cbd-51e321e5b087@arm.com> (raw)
In-Reply-To: <20210811024247.1144246-5-stevensd@google.com>
On 2021-08-11 03:42, David Stevens wrote:
> From: David Stevens <stevensd@chromium.org>
>
> Introduce a new dev_use_swiotlb function to guard swiotlb code, instead
> of overloading dev_is_untrusted. This allows CONFIG_SWIOTLB to be
> checked more broadly, so the swiotlb related code can be removed more
> aggressively.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> drivers/iommu/dma-iommu.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
> index be0214b1455c..89b689bf801f 100644
> --- a/drivers/iommu/dma-iommu.c
> +++ b/drivers/iommu/dma-iommu.c
> @@ -317,6 +317,11 @@ static bool dev_is_untrusted(struct device *dev)
> return dev_is_pci(dev) && to_pci_dev(dev)->untrusted;
> }
>
> +static bool dev_use_swiotlb(struct device *dev)
> +{
> + return IS_ENABLED(CONFIG_SWIOTLB) && dev_is_untrusted(dev);
> +}
> +
> /**
> * iommu_dma_init_domain - Initialise a DMA mapping domain
> * @domain: IOMMU domain previously prepared by iommu_get_dma_cookie()
> @@ -553,8 +558,7 @@ static dma_addr_t __iommu_dma_map_swiotlb(struct device *dev, phys_addr_t phys,
> * If both the physical buffer start address and size are
> * page aligned, we don't need to use a bounce page.
> */
> - if (IS_ENABLED(CONFIG_SWIOTLB) && dev_is_untrusted(dev) &&
> - iova_offset(iovad, phys | org_size)) {
> + if (dev_use_swiotlb(dev) && iova_offset(iovad, phys | org_size)) {
> aligned_size = iova_align(iovad, org_size);
> phys = swiotlb_tbl_map_single(dev, phys, org_size,
> aligned_size, dir, attrs);
> @@ -779,7 +783,7 @@ static void iommu_dma_sync_single_for_cpu(struct device *dev,
> {
> phys_addr_t phys;
>
> - if (dev_is_dma_coherent(dev) && !dev_is_untrusted(dev))
> + if (dev_is_dma_coherent(dev) && !dev_use_swiotlb(dev))
> return;
>
> phys = iommu_iova_to_phys(iommu_get_dma_domain(dev), dma_handle);
> @@ -795,7 +799,7 @@ static void iommu_dma_sync_single_for_device(struct device *dev,
> {
> phys_addr_t phys;
>
> - if (dev_is_dma_coherent(dev) && !dev_is_untrusted(dev))
> + if (dev_is_dma_coherent(dev) && !dev_use_swiotlb(dev))
> return;
>
> phys = iommu_iova_to_phys(iommu_get_dma_domain(dev), dma_handle);
> @@ -813,10 +817,10 @@ static void iommu_dma_sync_sg_for_cpu(struct device *dev,
> struct scatterlist *sg;
> int i;
>
> - if (dev_is_dma_coherent(dev) && !dev_is_untrusted(dev))
> + if (dev_is_dma_coherent(dev) && !dev_use_swiotlb(dev))
> return;
>
> - if (dev_is_untrusted(dev))
> + if (dev_use_swiotlb(dev))
> for_each_sg(sgl, sg, nelems, i)
> iommu_dma_sync_single_for_cpu(dev, sg_dma_address(sg),
> sg->length, dir);
> @@ -832,10 +836,10 @@ static void iommu_dma_sync_sg_for_device(struct device *dev,
> struct scatterlist *sg;
> int i;
>
> - if (dev_is_dma_coherent(dev) && !dev_is_untrusted(dev))
> + if (dev_is_dma_coherent(dev) && !dev_use_swiotlb(dev))
> return;
>
> - if (dev_is_untrusted(dev))
> + if (dev_use_swiotlb(dev))
> for_each_sg(sgl, sg, nelems, i)
> iommu_dma_sync_single_for_device(dev,
> sg_dma_address(sg),
> @@ -999,7 +1003,7 @@ static int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg,
> iommu_deferred_attach(dev, domain))
> return 0;
>
> - if (dev_is_untrusted(dev))
> + if (dev_use_swiotlb(dev))
> return iommu_dma_map_sg_swiotlb(dev, sg, nents, dir, attrs);
>
> if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC)) {
> @@ -1078,7 +1082,7 @@ static void iommu_dma_unmap_sg(struct device *dev, struct scatterlist *sg,
> attrs |= DMA_ATTR_SKIP_CPU_SYNC;
> }
>
> - if (dev_is_untrusted(dev)) {
> + if (dev_use_swiotlb(dev)) {
> iommu_dma_unmap_sg_swiotlb(dev, sg, nents, dir, attrs);
> return;
> }
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-08-11 19:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 2:42 [PATCH v3 0/5] Fixes for dma-iommu swiotlb bounce buffers David Stevens
2021-08-11 2:42 ` [PATCH v3 1/5] dma-iommu: fix sync_sg with swiotlb David Stevens
2021-08-11 5:57 ` Christoph Hellwig
2021-08-11 18:22 ` Robin Murphy
2021-08-11 2:42 ` [PATCH v3 2/5] dma-iommu: fix arch_sync_dma for map David Stevens
2021-08-11 6:01 ` Christoph Hellwig
2021-08-11 18:47 ` Robin Murphy
2021-08-12 9:21 ` David Stevens
2021-08-12 10:38 ` Robin Murphy
2021-08-11 2:42 ` [PATCH v3 3/5] dma-iommu: add SKIP_CPU_SYNC after syncing David Stevens
2021-08-11 6:07 ` Christoph Hellwig
2021-08-11 19:00 ` Robin Murphy
2021-08-11 2:42 ` [PATCH v3 4/5] dma-iommu: Check CONFIG_SWIOTLB more broadly David Stevens
2021-08-11 19:02 ` Robin Murphy [this message]
2021-08-11 2:42 ` [PATCH v3 5/5] dma-iommu: account for min_align_mask David Stevens
2021-08-11 9:26 ` Mi, Dapeng1
2021-08-11 19:12 ` Robin Murphy
2021-08-12 1:45 ` David Stevens
2021-08-12 9:57 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=681553ad-df37-a469-8cbd-51e321e5b087@arm.com \
--to=robin.murphy@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
--cc=stevensd@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox