From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5A1B3D72; Mon, 14 Aug 2023 05:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691989330; x=1723525330; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=qwK+HZvZ0fxHQu3F1Z1BO2CvSFGyEyEeAyWPyrYe3b0=; b=TsvayBBXV5l/N/D0E1SRhosihLgPRRlwPd0Yl3po84OyZbRLuvCaYz1j ms9UZz1v7O4k/vlK/kh3vzv7ndHjJW/GcTqwX92xwiFyClJR0A6MSuNxO gIUUo4IJ6I8Zp5hoVHCFUYQ0IG9hd8rl9qV8KwsdYZGa3FpDefCN/yG13 6yusBf8Y5Lz+z+qkLIqzhe9+dTt6WV9SNJyul7lfPbrsyJd+BElR1D8Ih tHTwmQYdgxM/tAe+hjehW2tNERVML5uKRoTDX9aszi48x4kxaWXw0a8ST AOeqtSzjENcO6OzK0rurM9I+fyp+gkWsbGa8MdLQPH7t6d/vKTyumt8z1 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="402945774" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="402945774" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 22:02:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="1063930020" X-IronPort-AV: E=Sophos;i="6.01,171,1684825200"; d="scan'208";a="1063930020" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.255.29.49]) ([10.255.29.49]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2023 22:01:57 -0700 Message-ID: <682666dc-3b43-5866-1025-0d0170eb4d86@linux.intel.com> Date: Mon, 14 Aug 2023 13:01:55 +0800 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: baolu.lu@linux.intel.com, Dmitry Osipenko , Marek Szyprowski , Nicolin Chen , Niklas Schnelle , Steven Price , Thierry Reding Subject: Re: [PATCH v6 11/25] iommu/tegra-smmu: Implement an IDENTITY domain Content-Language: en-US To: Jason Gunthorpe , Andy Gross , Alim Akhtar , Bjorn Andersson , AngeloGioacchino Del Regno , Baolin Wang , Christophe Leroy , Gerald Schaefer , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Kevin Tian , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Russell King , linuxppc-dev@lists.ozlabs.org, Matthias Brugger , Matthew Rosato , Michael Ellerman , Nicholas Piggin , Orson Zhai , Rob Clark , Robin Murphy , Samuel Holland , Thierry Reding , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Yong Wu , Chunyan Zhang References: <11-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> From: Baolu Lu In-Reply-To: <11-v6-e8114faedade+425-iommu_all_defdom_jgg@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023/8/3 8:07, Jason Gunthorpe wrote: > What tegra-smmu does during tegra_smmu_set_platform_dma() is actually > putting the iommu into identity mode. > > Move to the new core support for ARM_DMA_USE_IOMMU by defining > ops->identity_domain. > > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/tegra-smmu.c | 37 ++++++++++++++++++++++++++++++++----- > 1 file changed, 32 insertions(+), 5 deletions(-) > > diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c > index 1cbf063ccf147a..f63f1d4f0bd10f 100644 > --- a/drivers/iommu/tegra-smmu.c > +++ b/drivers/iommu/tegra-smmu.c > @@ -511,23 +511,39 @@ static int tegra_smmu_attach_dev(struct iommu_domain *domain, > return err; > } > > -static void tegra_smmu_set_platform_dma(struct device *dev) > +static int tegra_smmu_identity_attach(struct iommu_domain *identity_domain, > + struct device *dev) > { > struct iommu_domain *domain = iommu_get_domain_for_dev(dev); > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > - struct tegra_smmu_as *as = to_smmu_as(domain); > - struct tegra_smmu *smmu = as->smmu; > + struct tegra_smmu_as *as; > + struct tegra_smmu *smmu; > unsigned int index; > > if (!fwspec) > - return; > + return -ENODEV; > > + if (domain == identity_domain || !domain) > + return 0; > + > + as = to_smmu_as(domain); > + smmu = as->smmu; > for (index = 0; index < fwspec->num_ids; index++) { > tegra_smmu_disable(smmu, fwspec->ids[index], as->id); > tegra_smmu_as_unprepare(smmu, as); > } > + return 0; > } > > +static struct iommu_domain_ops tegra_smmu_identity_ops = { > + .attach_dev = tegra_smmu_identity_attach, > +}; > + > +static struct iommu_domain tegra_smmu_identity_domain = { > + .type = IOMMU_DOMAIN_IDENTITY, > + .ops = &tegra_smmu_identity_ops, > +}; > + > static void tegra_smmu_set_pde(struct tegra_smmu_as *as, unsigned long iova, > u32 value) > { > @@ -962,11 +978,22 @@ static int tegra_smmu_of_xlate(struct device *dev, > return iommu_fwspec_add_ids(dev, &id, 1); > } > > +static int tegra_smmu_def_domain_type(struct device *dev) > +{ > + /* > + * FIXME: For now we want to run all translation in IDENTITY mode, due > + * to some device quirks. Better would be to just quirk the troubled > + * devices. > + */ > + return IOMMU_DOMAIN_IDENTITY; > +} Hope somebody can fix this later on. Reviewed-by: Lu Baolu Best regards, baolu