From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B3C12676D9 for ; Fri, 27 Jun 2025 14:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751034879; cv=none; b=StrHF0WLB9KKE0/+RP0LcgcWr6NlTDWwfHlygVM2HYaJEekoyEqrDVE3p55UurBJqzoHs/NIMsODQmfW6+gbC4F7Rrq/bncCmdExenTgkBBnBpge3wPr6M+aFD1x+EwYFOdPrdnpzPGTKVznyj74mvWg/d39/iJ87+Mvdyl7NuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751034879; c=relaxed/simple; bh=y8WWwQD7QAEbVl1ij6mKyN6rfl5lkj802t9FgCkxabI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jlgPOUQELaD60B5fWEbkMCXPntbGguJYoC1qz89k5I90zZWmXJxJrV8DqFW1gDfJvTogsKF5gZPfhk4cxrVypX317D+JCXQDIqmBV7Wv+kNJL+hCsZPp//CC7D6gsCJc3MQO/pb7Y9SvVYqNsQLQfX1lCdC3zdi3j327YdKilGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=g9kGyX0S; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="g9kGyX0S" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55RC5WPN006912 for ; Fri, 27 Jun 2025 14:34:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1E10iKKXP8Jigq9QsX9VmVPYxg5Fdzb0t1IfPqsxsEI=; b=g9kGyX0SrxzJSgxU fMyEz0PRGbEHZKYpUIxtxM+1dkkupe9F8q5VSUopcAyD2dHWwX/T5DhqauMK5j3x rd79ABHBHMsyA66zZ93D2n0IDS/Vi5+0Pv7CPABsXYICoBio3GICBQqZwT4aR6lm h3aR21xuFGQaxn8dCCehwAy+4ZIttuZkbBknLk0BHFfhCrIobfeNZe+zEKFhyyN/ lDX/eXmoE7heITzvXuG3KR5bfOT6tbv08U9sYw36rBvuYCKK4lPfl7WdqJBV5ZaN 1WpGoI6JJ28uOcB1gMHM9dk1vdg1IBRlijSSB1FOYT3JmPQbuemcQ54DiSBko2Vj D/liPA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47evc60ae4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 27 Jun 2025 14:34:30 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7d2038aae69so2757885a.0 for ; Fri, 27 Jun 2025 07:34:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751034869; x=1751639669; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1E10iKKXP8Jigq9QsX9VmVPYxg5Fdzb0t1IfPqsxsEI=; b=tIKvP3Mt23rAsih2sIcgKkcsr3EZX7wESVOLe5KMgnV4f9aUOHcLE9fS0HUHA8+JCP FlnKGi6LdvjlAvVqZbGgTmiSNQTtKcgO+p5YC5dz//14g9pWPSzBgrOJyaleZelDTm/J HHIM1MCEV83W9F7GM1dbaD8oeWTQu4LbXvztHvR07FsvUwT4Pr0CZdnyxG2GrpTiwzBo IZ/Y3G36TdGJh9ZczthbEJRmojdk6zqN7xW6JJtoDYGTe4iErATHflK8yb1Mlkr0dCrC 5/StRJ6iGvh2+xr9bDWZBHtCyD9JNj7X/jYqsEuLrkiP2/pNs6/jKETUNU87emm8V9eG YprA== X-Forwarded-Encrypted: i=1; AJvYcCXnheeuN3yjFRUXojK5j51OoPDIMlENGuWfMp58WpfTNMskLqKzq4b+ssFTjvlfN/ERvoyeVw==@lists.linux.dev X-Gm-Message-State: AOJu0Yxi+axvgYNsmiFv/lC66qYzvzBd6Yk7Y8+TEsYYlH1DeXNZSbTp RVmXCzPS4ZsI2xjNe9ErElIvL8jbic2gS9TLmq9rHVJtre0lDdXosXNNH14fla61EBcHuVlayvV BvWbtm0sFwNixRz3zptDWsp6xcu8F0jZfyWbEWC1s7Es4JO1rwwvM14tFvg== X-Gm-Gg: ASbGncvZeKQP9NA5q2FEnEWCJTQqsB69dmNbDGi5s5cB90rQbAKe0qJBtN6RsAn9izi 3m1VueqQICIFvsIZxv/4GXYUojjrf6GBMd6DnG4dKkrCPRtja/hSHG0k//zkXdcINA6Vcf0phSB NTdZYSyvUAQo2gTIIxD/nkWX/EC5hp6qMNxj1jSir11QPbs3f2waTtmf23A0ya7SsLUmz2+273n DSkikGb5lnwH8Cm+gZ65NsMK+XyWig0NRE2d50L/dJYcy8rQdIUIzPWLF5LiMgRgDz5v0IueQD5 csJbP4rxiXhr5YnA2KeRoEAaZ9olWl2jXpyMNwzrWDnqYezvoadIZGC/M6Aasn/jw/y8Q7UKODG sZvg= X-Received: by 2002:a05:620a:684a:b0:7d3:c688:a590 with SMTP id af79cd13be357-7d4438f895dmr150828885a.4.1751034869339; Fri, 27 Jun 2025 07:34:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGL+0Argf/YR+lQnOb5qAOTTQjAM3ncoqVGAETIjGQblJ3e07wKcIT22ODvigY7oQFVVuPf0Q== X-Received: by 2002:a05:620a:684a:b0:7d3:c688:a590 with SMTP id af79cd13be357-7d4438f895dmr150824885a.4.1751034868338; Fri, 27 Jun 2025 07:34:28 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c015c3sm132768266b.100.2025.06.27.07.34.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 07:34:27 -0700 (PDT) Message-ID: <6d4e77b3-0f92-44dd-b9b0-3129a5f3785b@oss.qualcomm.com> Date: Fri, 27 Jun 2025 16:34:23 +0200 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 14/14] arm64: dts: qcom: Add The Fairphone (Gen. 6) To: Luca Weiss , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Viresh Kumar , Manivannan Sadhasivam , Herbert Xu , "David S. Miller" , Vinod Koul , Bjorn Andersson , Konrad Dybcio , Robert Marko , Das Srinagesh , Thomas Gleixner , Jassi Brar , Amit Kucheria , Thara Gopinath , Daniel Lezcano , Zhang Rui , Lukasz Luba , Ulf Hansson Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-mmc@vger.kernel.org References: <20250625-sm7635-fp6-initial-v1-0-d9cd322eac1b@fairphone.com> <20250625-sm7635-fp6-initial-v1-14-d9cd322eac1b@fairphone.com> <4200b3b8-5669-4d5a-a509-d23f921b0449@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 2R4LmzZ-J72KY_vGxUJiaPCnJkS0qLfO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI3MDExOSBTYWx0ZWRfX6E7uTdiXVw12 BbnQMlibMK2Z25+1Ton0pZiUjcmgmYODXtQ47zPNqlXTVSnJnxUe0noCGKejwtYMDN6WEvQKafG znF4qT0XpF28TnLs2OGxPpd3lMZTAjFDU5V63EPbqsrUO4O0EM5MMJm/3dXTdz52LT1sGz7eXYS dCYtUXciVC1e9Oq9q1JXbGBCwVYInNvDiiPD08CB3Wvz3aOnzQuUuK6dH7J2CVerDAZOxzYX4Yn G5zMwCujJB3l/UmKyNbtShzZ70cI61TY38t5uPms/+CDAe8DIdIXi0dx9zeNyh4HU2JLQN4oDFr miFCn/5S0l9Rfxzow98jAmMH0Fkt/Muov/Ei6PPPGQzX372FMbcTjrfAn8tsc58Ky95Yhhav5x8 Rjb/JeLGdXs8tq2wZiAWszPiMMv7UOrGVUo34qE2CxQ3cQ6A1R79wrmo+CsaMJWzaDfr2Eol X-Authority-Analysis: v=2.4 cv=caHSrmDM c=1 sm=1 tr=0 ts=685eabf6 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=Sqmq4kN4DPMvB5fHc-YA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 2R4LmzZ-J72KY_vGxUJiaPCnJkS0qLfO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-27_04,2025-06-26_05,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 suspectscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506270119 On 6/27/25 1:33 PM, Luca Weiss wrote: > On Wed Jun 25, 2025 at 4:38 PM CEST, Konrad Dybcio wrote: >> On 6/25/25 11:23 AM, Luca Weiss wrote: >>> Add a devicetree for The Fairphone (Gen. 6) smartphone, which is based >>> on the SM7635 SoC. >> >> [...] >> >>> + /* Dummy panel for simple-framebuffer dimension info */ >>> + panel: panel { >>> + compatible = "boe,bj631jhm-t71-d900"; >>> + width-mm = <65>; >>> + height-mm = <146>; >>> + }; >> >> I haven't ran through all the prerequisite-xx-id, but have >> you submitted a binding for this? > > Actually not, kind of forgot about this. I believe I can create a > (mostly?) complete binding for the panel, but this simple description > for only width-mm & height-mm will differ from the final one, which will > have the DSI port, pinctrl, reset-gpios and various supplies. > > I think I'll just drop it from v2 and keep it locally only, to get the > simpledrm scaling right. Yeah I think that'd be best in general > >> >> [...] >> >>> + reserved-memory { >>> + /* >>> + * ABL is powering down display and controller if this node is >>> + * not named exactly "splash_region". >>> + */ >>> + splash_region@e3940000 { >>> + reg = <0x0 0xe3940000 0x0 0x2b00000>; >>> + no-map; >>> + }; >>> + }; >> >> :/ maybe we can convince ABL not to do it.. > > Yes, we talked about that. I will look into getting "splash-region" and > "splash" also into the ABL (edk2) build for the phone. Still won't > resolve that for any other brand of devices. Gotta start small! Maybe framebuffer@ would be more """idiomatic""" but potayto/potahto > >> >> [...] >> >>> + vreg_l12b: ldo12 { >>> + regulator-name = "vreg_l12b"; >>> + /* >>> + * Skip voltage voting for UFS VCC. >>> + */ >> >> Why so? > > From downstream: > > /* > * This is for UFS Peripheral,which supports 2 variants > * UFS 3.1 ,and UFS 2.2 both require different voltages. > * Hence preventing voltage voting as per previous targets. > */ > > I haven't (successfully) brought up UFS yet, so I haven't looked more > into that. > > The storage on FP6 is UFS 3.1 though fwiw. Hm.. can you check what debugfs says about the voltage at runtime (on downstream)? I'd assume you won't be shipping two kinds anyway [...] >>> +&pm8550vs_d { >>> + status = "disabled"; >>> +}; >>> + >>> +&pm8550vs_e { >>> + status = "disabled"; >>> +}; >>> + >>> +&pm8550vs_g { >>> + status = "disabled"; >>> +}; >> >> Hm... perhaps we should disable these by deafult > > Do you want me to do this in this patchset, or we clean this up later at > some point? I'd prefer not adding even more dependencies to my patch > collection right now. I can totally hear that.. Let's include it in this patchset, right before SoC addition I don't think there's any pm8550vs users trying to get merged in parallel so it should be OK [...] >>> +&usb_1 { >>> + dr_mode = "otg"; >>> + >>> + /* USB 2.0 only */ >> >> Because there's no usb3phy description yet, or due to hw design? > > HW design. Funnily enough with clk_ignore_unused this property is not > needed, and USB(2.0) works fine then. Just when (I assume) the USB3 > clock is turned off which the bootloader has enabled, USB stops working. The USB controller has two possible clock sources: the PIPE_CLK that the QMPPHY outputs, or the UTMI clock (qcom,select-utmi-as-pipe-clk). Because you said there's no USB3, I'm assuming DP-over-Type-C won't be a thing either? :( Konrad