From: Lu Baolu <baolu.lu@linux.intel.com>
To: Megha Dey <megha.dey@linux.intel.com>,
dwmw2@infradead.org, iommu@lists.linux-foundation.org
Cc: megha.dey@intel.com
Subject: Re: [Patch V1 1/2] iommu/vt-d: Fix debugfs register reads
Date: Tue, 10 Mar 2020 09:25:55 +0800 [thread overview]
Message-ID: <6d55f086-7c84-c9fa-6207-387ccf1ef9a9@linux.intel.com> (raw)
In-Reply-To: <1583784587-26126-2-git-send-email-megha.dey@linux.intel.com>
On 2020/3/10 4:09, Megha Dey wrote:
> Commit 6825d3ea6cde ("iommu/vt-d: Add debugfs support to show register
> contents") dumps the register contents for all IOMMU devices.
>
> Currently, a 64 bit read(dmar_readq) is done for all the IOMMU registers,
> even though some of the registers are 32 bits, which is incorrect.
>
> Use the correct read function variant (dmar_readl/dmar_readq) while
> reading the contents of 32/64 bit registers respectively.
>
> Signed-off-by: Megha Dey <megha.dey@linux.intel.com>
Fixes: 6825d3ea6cdea ("iommu/vt-d: Add debugfs support to show register
contents")
Cc: Cc: stable@vger.kernel.org # v4.20
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-03-10 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 20:09 [Patch V1 0/2] iommu/vtd: Fixes to the IOMMU debugfs Megha Dey
2020-03-09 20:09 ` [Patch V1 1/2] iommu/vt-d: Fix debugfs register reads Megha Dey
2020-03-10 1:25 ` Lu Baolu [this message]
2020-03-09 20:09 ` [Patch V1 2/2] iommu/vt-d: Populate debugfs if IOMMUs are detected Megha Dey
2020-03-10 0:50 ` [Patch V1 0/2] iommu/vtd: Fixes to the IOMMU debugfs Lu Baolu
2020-03-10 10:51 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d55f086-7c84-c9fa-6207-387ccf1ef9a9@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=megha.dey@intel.com \
--cc=megha.dey@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox