Linux IOMMU Development
 help / color / mirror / Atom feed
From: Nadav Amit <namit@vmware.com>
To: Jon Pan-Doh <pandoh@google.com>
Cc: Joerg Roedel <joro@8bytes.org>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sudheer Dantuluri <dantuluris@google.com>,
	Gary Zibrat <gzibrat@google.com>
Subject: Re: [PATCH] iommu/amd: Fix domain flush size when syncing iotlb
Date: Wed, 17 May 2023 05:58:43 +0000	[thread overview]
Message-ID: <71A3F44C-B684-4946-AF11-3DB98E3AC641@vmware.com> (raw)
In-Reply-To: <CAMC_AXUkiHvBaWQm8fnAbgbxe59iF9UM59=yBoa3LcuLGQ=E3A@mail.gmail.com>


> On May 16, 2023, at 10:49 PM, Jon Pan-Doh <pandoh@google.com> wrote:
> 
> !! External Email
> 
> On Wed, Apr 26, 2023 at 1:32 PM Jon Pan-Doh <pandoh@google.com> wrote:
>> 
>> When running on an AMD vIOMMU, we observed multiple invalidations (of
>> decreasing power of 2 aligned sizes) when unmapping a single page.
>> 
>> Domain flush takes gather bounds (end-start) as size param. However,
>> gather->end is defined as the last inclusive address (start + size - 1).
>> This leads to an off by 1 error.
>> 
>> With this patch, verified that 1 invalidation occurs when unmapping a
>> single page.
>> 
>> Fixes: a270be1b3fdf ("iommu/amd: Use only natural aligned flushes in a VM")
>> Signed-off-by: Jon Pan-Doh <pandoh@google.com>
>> Tested-by: Sudheer Dantuluri <dantuluris@google.com>
>> Suggested-by: Gary Zibrat <gzibrat@google.com>
> 
> Cc: stable@vger.kernel.org

Assuming the patch was still not applied, I think that Greg KH would
prefer that you send v2 that includes the “Cc: <stable@vger.kernel.org>”
(notice the “<“ and “>" signs) and ideally the version in which I added
the buggy code (sorry for that again) after a “#” sign.

I think it is version 5.15.

IOW: If the patch was still not applied by Joerg, please send v2 with:

Cc: <stable@vger.kernel.org <mailto:stable@vger.kernel.org>> # 5.15.x

In the commit log.


  reply	other threads:[~2023-05-17  5:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 20:32 [PATCH] iommu/amd: Fix domain flush size when syncing iotlb Jon Pan-Doh
2023-04-26 21:04 ` Nadav Amit
2023-04-26 21:22   ` Nadav Amit
2023-04-28  5:20 ` Vasant Hegde
2023-05-16 20:59 ` Jon Pan-Doh
2023-05-17  4:38   ` Greg KH
2023-05-17  5:54     ` Jon Pan-Doh
2023-05-17  5:49 ` Jon Pan-Doh
2023-05-17  5:58   ` Nadav Amit [this message]
2023-05-18  2:05     ` Jon Pan-Doh
2023-05-22 15:34 ` Joerg Roedel
  -- strict thread matches above, loose matches on Subject: below --
2023-05-05  1:43 Jon Pan-Doh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71A3F44C-B684-4946-AF11-3DB98E3AC641@vmware.com \
    --to=namit@vmware.com \
    --cc=dantuluris@google.com \
    --cc=gzibrat@google.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pandoh@google.com \
    --cc=robin.murphy@arm.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox