iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Jonathan Hunter
	<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 1/2] iommu/tegra: gart: Optionally check for overwriting of page mappings
Date: Fri, 13 Oct 2017 15:52:52 +0300	[thread overview]
Message-ID: <71a0e4c6-714f-cb0d-57f6-250c0c1cd40a@gmail.com> (raw)
In-Reply-To: <20171013083848.GA29513-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>

On 13.10.2017 11:38, Joerg Roedel wrote:
> On Thu, Oct 12, 2017 at 05:27:26PM +0300, Dmitry Osipenko wrote:
>> I'm not talking about any specific bug, but in general if allocator re-maps
>> already mapped region or unmaps the wrong-and-used region. I had those bug-cases
>> during of development of the 'scattered' graphics allocations for Tegra20.
> 
> The dma-iommu code does not re-map already mapped regions and it doesn't
> unmap wrong regions. If it does it should be reported and fixed.
> 

Certainly iommu_map_sg doesn't perform itself any debug checks that I'm
proposing to add to the GART.

Yet we don't use GART in the mainline, right now you may take a look at the WIP
patches here:

https://github.com/grate-driver/linux/commit/9853371164a7f1b5698caee476e7cffe1b446afa

https://github.com/grate-driver/linux/commit/ea1fca4ac932464e7907a7ada8ea2698cab8db65

> So if you hit any bug there, please report it so that it can be fixed.
> 

  parent reply	other threads:[~2017-10-13 12:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04  1:02 [PATCH v2 0/2] TEGRA GART cleanup and new debug option Dmitry Osipenko
     [not found] ` <cover.1507078586.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
     [not found]   ` <cover.1507078770.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-04  1:02     ` [PATCH v2 1/2] iommu/tegra: gart: Add optional debug checking for overwriting of page mappings Dmitry Osipenko
     [not found]       ` <2eadfde76987532354e419ffc98aae44e4af489a.1507078586.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-04  1:12         ` Dmitry Osipenko
2017-10-04  1:02     ` [PATCH v2 1/2] iommu/tegra: gart: Optionally check " Dmitry Osipenko
     [not found]       ` <7eea4a30b0f4fdbe14351cf2c6cf537365080d2d.1507078770.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-10  9:53         ` Joerg Roedel
     [not found]           ` <20171010095342.jyvzl2zex2pynqvv-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-10-12 14:27             ` Dmitry Osipenko
     [not found]               ` <7dc66d59-3904-d1f8-3941-f9a534ff899a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-13  8:38                 ` Joerg Roedel
     [not found]                   ` <20171013083848.GA29513-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-10-13 12:52                     ` Dmitry Osipenko [this message]
2017-10-04  1:02     ` [PATCH v2 2/2] iommu/tegra: gart: Move PFN validation out of spinlock Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71a0e4c6-714f-cb0d-57f6-250c0c1cd40a@gmail.com \
    --to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).