From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC30517CF for ; Sat, 6 Jan 2024 04:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iqPpVzrb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704513843; x=1736049843; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PvYiBAvbCc1PtL2eLMohgTUZrYB4MkX6teoGHMh0kkU=; b=iqPpVzrbSvDYUKsKvI/doo8L2qiSCeUrV0Q6KsszkhibZbXrzdybqtfl i6qaPUE93JiSYkE3ZILD6KYcUH4DEjWoMnq7sWVk6CDAfq11rblmyjPYe aoiyo/k4d50y2vfZp/LW9tgCK+chObSHSgHc6hDK5Deiqw//9T2eJTgvc dBk7EyFhxDYQMsyA0I6EI25Cl9fPJYSWPOTBLR46NVNulW60UrglcntD7 m3wdOtxPfUOwKWy1V7UOdo1BXRIn0Nz5FsrVY/OpxgL7namluYDN2dsRU SM2iiFrynjPqlQurr6zSXDYXmssJQR1fQoceyhBkru4G/Ag9uum8RVy/Z g==; X-IronPort-AV: E=McAfee;i="6600,9927,10944"; a="464034080" X-IronPort-AV: E=Sophos;i="6.04,335,1695711600"; d="scan'208";a="464034080" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2024 20:04:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10944"; a="774009166" X-IronPort-AV: E=Sophos;i="6.04,335,1695711600"; d="scan'208";a="774009166" Received: from zhaohaif-mobl.ccr.corp.intel.com (HELO [10.93.16.94]) ([10.93.16.94]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2024 20:03:59 -0800 Message-ID: <7363f8c1-8ab6-4c3e-8f32-d7ab8e9244f1@linux.intel.com> Date: Sat, 6 Jan 2024 12:03:57 +0800 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] iommu/iova: Make the rcache depot properly flexible To: Ido Schimmel , Robin Murphy Cc: joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, zhangzekun11@huawei.com, john.g.garry@oracle.com, dheerajkumar.srivastava@amd.com, jsnitsel@redhat.com References: From: Ethan Zhao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/28/2023 8:23 PM, Ido Schimmel wrote: > On Tue, Sep 12, 2023 at 05:28:04PM +0100, Robin Murphy wrote: >> v2: https://lore.kernel.org/linux-iommu/cover.1692641204.git.robin.murphy@arm.com/ >> >> Hi all, >> >> I hope this is good to go now, just fixed the locking (and threw >> lockdep at it to confirm, which of course I should have done to begin >> with...) and picked up tags. > Hi, > > After pulling the v6.7 changes we started seeing the following memory > leaks [1] of 'struct iova_magazine'. I'm not sure how to reproduce it, > which is why I didn't perform bisection. However, looking at the > mentioned code paths, they seem to have been changed in v6.7 as part of > this patchset. I reverted both patches and didn't see any memory leaks > when running a full regression (~10 hours), but I will repeat it to be > sure. > > Any idea what could be the problem? > > Thanks > > [1] > unreferenced object 0xffff8881a5301000 (size 1024): size 1024, seems one "iova_magazine" was leaked ? no other struct happens to be size 1024. Thanks, Ethan > comm "softirq", pid 0, jiffies 4306297099 (age 462.991s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 e7 7d 05 00 00 00 00 00 .........}...... > 0f b4 05 00 00 00 00 00 b4 96 05 00 00 00 00 00 ................ > backtrace: > [] __kmem_cache_alloc_node+0x1e8/0x320 > [] kmalloc_trace+0x2a/0x60 > [] free_iova_fast+0x28e/0x4e0 > [] fq_ring_free_locked+0x1b0/0x310 > [] fq_flush_timeout+0x19d/0x2e0 > [] call_timer_fn+0x19a/0x5c0 > [] __run_timers+0x78b/0xb80 > [] run_timer_softirq+0x5d/0xd0 > [] __do_softirq+0x205/0x8b5 > > unreferenced object 0xffff8881392ec000 (size 1024): > comm "softirq", pid 0, jiffies 4306326731 (age 433.359s) > hex dump (first 32 bytes): > 00 10 30 a5 81 88 ff ff 50 ff 0f 00 00 00 00 00 ..0.....P....... > f3 99 05 00 00 00 00 00 87 b7 05 00 00 00 00 00 ................ > backtrace: > [] __kmem_cache_alloc_node+0x1e8/0x320 > [] kmalloc_trace+0x2a/0x60 > [] free_iova_fast+0x28e/0x4e0 > [] fq_ring_free_locked+0x1b0/0x310 > [] fq_flush_timeout+0x19d/0x2e0 > [] call_timer_fn+0x19a/0x5c0 > [] __run_timers+0x78b/0xb80 > [] run_timer_softirq+0x5d/0xd0 > [] __do_softirq+0x205/0x8b5 > > unreferenced object 0xffff8881411f9000 (size 1024): > comm "softirq", pid 0, jiffies 4306708887 (age 51.459s) > hex dump (first 32 bytes): > 00 10 1c 26 81 88 ff ff 2c 96 05 00 00 00 00 00 ...&....,....... > ac fe 0f 00 00 00 00 00 a6 fe 0f 00 00 00 00 00 ................ > backtrace: > [] __kmem_cache_alloc_node+0x1e8/0x320 > [] kmalloc_trace+0x2a/0x60 > [] free_iova_fast+0x28e/0x4e0 > [] fq_ring_free_locked+0x1b0/0x310 > [] fq_flush_timeout+0x19d/0x2e0 > [] call_timer_fn+0x19a/0x5c0 > [] __run_timers+0x78b/0xb80 > [] run_timer_softirq+0x5d/0xd0 > [] __do_softirq+0x205/0x8b5 > > unreferenced object 0xffff88812be26400 (size 1024): > comm "softirq", pid 0, jiffies 4306710027 (age 50.319s) > hex dump (first 32 bytes): > 00 c0 2e 39 81 88 ff ff 32 ab 05 00 00 00 00 00 ...9....2....... > e3 ac 05 00 00 00 00 00 1f b6 05 00 00 00 00 00 ................ > backtrace: > [] __kmem_cache_alloc_node+0x1e8/0x320 > [] kmalloc_trace+0x2a/0x60 > [] free_iova_fast+0x28e/0x4e0 > [] fq_ring_free_locked+0x1b0/0x310 > [] fq_flush_timeout+0x19d/0x2e0 > [] call_timer_fn+0x19a/0x5c0 > [] __run_timers+0x78b/0xb80 > [] run_timer_softirq+0x5d/0xd0 > [] __do_softirq+0x205/0x8b5 > > unreferenced object 0xffff8881261c1000 (size 1024): > comm "softirq", pid 0, jiffies 4306711547 (age 48.799s) > hex dump (first 32 bytes): > 00 64 e2 2b 81 88 ff ff c0 7c 05 00 00 00 00 00 .d.+.....|...... > 87 a5 05 00 00 00 00 00 0e 9a 05 00 00 00 00 00 ................ > backtrace: > [] __kmem_cache_alloc_node+0x1e8/0x320 > [] kmalloc_trace+0x2a/0x60 > [] free_iova_fast+0x28e/0x4e0 > [] fq_ring_free_locked+0x1b0/0x310 > [] fq_flush_timeout+0x19d/0x2e0 > [] call_timer_fn+0x19a/0x5c0 > [] __run_timers+0x78b/0xb80 > [] run_timer_softirq+0x5d/0xd0 > [] __do_softirq+0x205/0x8b5 >