From: Lu Baolu <baolu.lu@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kevin.tian@intel.com, ashok.raj@intel.com,
linux-kernel@vger.kernel.org, Daniel Drake <drake@endlessm.com>,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Derrick Jonathan <jonathan.derrick@intel.com>
Subject: Re: [PATCH v3 1/3] iommu/vt-d: Allow 32bit devices to uses DMA domain
Date: Fri, 17 Apr 2020 20:49:53 +0800 [thread overview]
Message-ID: <741e4882-969f-b102-f91a-f2ef86b6fb90@linux.intel.com> (raw)
In-Reply-To: <20200417065054.GA18880@lst.de>
Hi Christoph,
On 2020/4/17 14:50, Christoph Hellwig wrote:
> On Thu, Apr 16, 2020 at 03:40:38PM +0800, Lu Baolu wrote:
>>> description. I'd need to look at the final code, but it seems like
>>> this will still cause bounce buffering instead of using dynamic
>>> mapping, which still seems like an awful idea.
>>
>> Yes. If the user chooses to use identity domain by default through
>> kernel command, identity domain will be applied for all devices. For
>> those devices with limited addressing capability, bounce buffering will
>> be used when they try to access the memory beyond their address
>> capability. This won't cause any kernel regression as far as I can see.
>>
>> Switching domain during runtime with drivers loaded will cause real
>> problems as I said in the commit message. That's the reason why I am
>> proposing to remove it. If we want to keep it, we have to make sure that
>> switching domain for one device should not impact other devices which
>> share the same domain with it. Furthermore, it's better to implement it
>> in the generic layer to keep device driver behavior consistent on all
>> architectures.
>
> I don't disagree with the technical points. What I pointed out is that
>
> a) the actual technical change is not in the commit log, which it
> should be
Sorry! I should make the commit message more comprehensive.
> b) that I still think taking away the ability to dynamically map
> devices in the identify domain after all the time we allowed for
> that is going to cause nasty regressions.
>
This change just asks Intel IOMMU driver to use the default domain
specified by the generic default domain framework, just like what other
vendor iommu drivers do. I understand that some users wants to use DMA
domain for some specific devices when the default domain type is
identity, and vice versa, use identity domain for some devices while
default one is DMA. I think Sai's patch series posted at
https://www.spinics.net/lists/iommu/msg41680.html
is a good start. It changes the default domain with all device drivers
unbound in the generic layer, hence every vendor iommu driver could
benefit from it.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-04-17 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 6:23 [PATCH v3 0/3] Replace private domain with per-group default domain Lu Baolu
2020-04-16 6:23 ` [PATCH v3 1/3] iommu/vt-d: Allow 32bit devices to uses DMA domain Lu Baolu
2020-04-16 7:01 ` Christoph Hellwig
2020-04-16 7:40 ` Lu Baolu
2020-04-17 6:50 ` Christoph Hellwig
2020-04-17 12:49 ` Lu Baolu [this message]
2020-04-16 6:23 ` [PATCH v3 2/3] iommu/vt-d: Allow PCI sub-hierarchy to use " Lu Baolu
2020-04-16 6:23 ` [PATCH v3 3/3] iommu/vt-d: Apply per-device dma_ops Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741e4882-969f-b102-f91a-f2ef86b6fb90@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=drake@endlessm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathan.derrick@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).