From: Vasant Hegde <vasant.hegde@amd.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Will Deacon <will@kernel.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Joerg Roedel <jroedel@suse.de>, Kevin Tian <kevin.tian@intel.com>,
Tony Zhu <tony.zhu@intel.com>, Yi Liu <yi.l.liu@intel.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: Re: [PATCH for-rc] iommu/amd: Add missing domain type checks
Date: Fri, 28 Apr 2023 10:54:06 +0530 [thread overview]
Message-ID: <7aed7aac-160c-d58d-428c-d20acf23da2d@amd.com> (raw)
In-Reply-To: <0-v1-2ac37b893728+da-amd_check_types_jgg@nvidia.com>
On 4/26/2023 12:34 AM, Jason Gunthorpe wrote:
> Drivers are supposed to list the domain types they support in their
> domain_alloc() ops so when we add new domain types, like BLOCKING or SVA,
> they don't start breaking.
>
> This ended up providing an empty UNMANAGED domain when the core code asked
> for a BLOCKING domain, which happens to be the fallback for drivers that
> don't support it, but this is completely wrong for SVA.
>
> Check for the DMA types AMD supports and reject every other kind.
>
> Fixes: 136467962e49 ("iommu: Add IOMMU SVA domain support")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Thanks! Patch looks good to me.
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
next prev parent reply other threads:[~2023-04-28 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 19:04 [PATCH for-rc] iommu/amd: Add missing domain type checks Jason Gunthorpe
2023-04-26 8:49 ` Tian, Kevin
2023-04-28 5:24 ` Vasant Hegde [this message]
2023-05-22 15:29 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aed7aac-160c-d58d-428c-d20acf23da2d@amd.com \
--to=vasant.hegde@amd.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=kevin.tian@intel.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tony.zhu@intel.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox