From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v7 15/19] irqdomain: irq_domain_check_msi_remap Date: Tue, 10 Jan 2017 11:54:12 +0000 Message-ID: <810b8c1d-ec2a-bef0-c771-e93d59d6c5be@arm.com> References: <1483969570-3154-1-git-send-email-eric.auger@redhat.com> <1483969570-3154-16-git-send-email-eric.auger@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1483969570-3154-16-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Eric Auger , eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org, alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, punit.agrawal-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 09/01/17 13:46, Eric Auger wrote: > This new function checks whether all MSI irq domains > implement IRQ remapping. This is useful to understand > whether VFIO passthrough is safe with respect to interrupts. > > On ARM typically an MSI controller can sit downstream > to the IOMMU without preventing VFIO passthrough. > As such any assigned device can write into the MSI doorbell. > In case the MSI controller implements IRQ remapping, assigned > devices will not be able to trigger interrupts towards the > host. On the contrary, the assignment must be emphasized as > unsafe with respect to interrupts. > > Signed-off-by: Eric Auger > > --- > v5 -> v6: > - use irq_domain_hierarchical_is_msi_remap() > - comment rewording > > v4 -> v5: > - Handle DOMAIN_BUS_FSL_MC_MSI domains > - Check parents > --- > include/linux/irqdomain.h | 1 + > kernel/irq/irqdomain.c | 23 +++++++++++++++++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h > index bc2f571..188eced 100644 > --- a/include/linux/irqdomain.h > +++ b/include/linux/irqdomain.h > @@ -222,6 +222,7 @@ struct irq_domain *irq_domain_add_legacy(struct device_node *of_node, > void *host_data); > extern struct irq_domain *irq_find_matching_fwspec(struct irq_fwspec *fwspec, > enum irq_domain_bus_token bus_token); > +extern bool irq_domain_check_msi_remap(void); > extern void irq_set_default_host(struct irq_domain *host); > extern int irq_domain_alloc_descs(int virq, unsigned int nr_irqs, > irq_hw_number_t hwirq, int node, > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index 101ee8f..fff30cb 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -278,6 +278,29 @@ struct irq_domain *irq_find_matching_fwspec(struct irq_fwspec *fwspec, > EXPORT_SYMBOL_GPL(irq_find_matching_fwspec); > > /** > + * irq_domain_check_msi_remap - Check whether all MSI > + * irq domains implement IRQ remapping > + */ > +bool irq_domain_check_msi_remap(void) > +{ > + struct irq_domain *h; > + bool ret = true; > + > + mutex_lock(&irq_domain_mutex); > + list_for_each_entry(h, &irq_domain_list, link) { > + if (irq_domain_is_msi(h) && > + !irq_domain_hierarchical_is_msi_remap(h)) { > + ret = false; > + goto out; Let's avoid gotos if we can. a break statement will have the same effect here, and we can drop the label. > + } > + } > +out: > + mutex_unlock(&irq_domain_mutex); > + return ret; > +} > +EXPORT_SYMBOL_GPL(irq_domain_check_msi_remap); > + > +/** > * irq_set_default_host() - Set a "default" irq domain > * @domain: default domain pointer > * > Thanks, M. -- Jazz is not dead. It just smells funny...