From: Robin Murphy <robin.murphy@arm.com>
To: Joerg Roedel <joro@8bytes.org>, Tom Murphy <murphyt7@tcd.ie>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Handle init_iova_flush_queue failure in dma-iommu path
Date: Fri, 18 Sep 2020 14:51:32 +0100 [thread overview]
Message-ID: <82d5f9c9-1001-3ed3-05f2-1a3b87ca023d@arm.com> (raw)
In-Reply-To: <20200918085501.GJ31590@8bytes.org>
On 2020-09-18 09:55, Joerg Roedel wrote:
> On Thu, Sep 10, 2020 at 01:25:38PM +0100, Tom Murphy wrote:
>> init_iova_flush_queue can fail if we run out of memory. Fall back to noflush
>> queue if it fails.
>>
>> Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
>> ---
>> drivers/iommu/dma-iommu.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
>> index 4959f5df21bd..5f69126f3e91 100644
>> --- a/drivers/iommu/dma-iommu.c
>> +++ b/drivers/iommu/dma-iommu.c
>> @@ -343,8 +343,11 @@ static int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base,
>>
>> if (!cookie->fq_domain && !iommu_domain_get_attr(domain,
>> DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE, &attr) && attr) {
>> - cookie->fq_domain = domain;
>> - init_iova_flush_queue(iovad, iommu_dma_flush_iotlb_all, NULL);
>> + if (init_iova_flush_queue(iovad, iommu_dma_flush_iotlb_all,
>> + NULL))
>> + pr_warn("iova flush queue initialization failed\n");
>> + else
>> + cookie->fq_domain = domain;
>> }
>>
>> if (!dev)
>
> Looks good to me, but Robin should also have a look.
Yup, seems reasonable, thanks Tom!
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-18 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 12:25 [PATCH] Handle init_iova_flush_queue failure in dma-iommu path Tom Murphy
2020-09-18 8:55 ` Joerg Roedel
2020-09-18 13:51 ` Robin Murphy [this message]
2020-09-18 15:14 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82d5f9c9-1001-3ed3-05f2-1a3b87ca023d@arm.com \
--to=robin.murphy@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox