From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47607C41604 for ; Wed, 7 Oct 2020 16:03:15 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B0822176B for ; Wed, 7 Oct 2020 16:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="RI/eM+2S"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="aqWokfyv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B0822176B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E5D04872A8; Wed, 7 Oct 2020 16:03:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1QeZ-lZ3sjJT; Wed, 7 Oct 2020 16:03:13 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 59565872A4; Wed, 7 Oct 2020 16:03:13 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3F582C07FF; Wed, 7 Oct 2020 16:03:13 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id EE759C0051 for ; Wed, 7 Oct 2020 16:03:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D290D872A7 for ; Wed, 7 Oct 2020 16:03:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n-PfCwDilcOg for ; Wed, 7 Oct 2020 16:03:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by hemlock.osuosl.org (Postfix) with ESMTPS id C5928872A5 for ; Wed, 7 Oct 2020 16:03:01 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602086579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/O9zXhP69EMhj/QeCm7nrD9DQq4LE8NEMX5F2vVATgA=; b=RI/eM+2S5vH/NncDytwt7k54fB7OvpP02d8g6KxKLwsB8XC3qMn05fzYGhjNibTLNMTJpr w/l7vnoIHEp++pNghC71NU1X6d1Z+uU7zFRzWjVig3KaWnl/XWH3TDXYF/8FILRizMwXVM asKtdY0JB7Wx5QN7ZQZZ8YL+WC4FLxO5JTzqF1wYks9U66MgUJFoE4vsEhkAJq/J+wKoXE xiVbPLzdi1GgKH8TI0DGruH4P5yyrJ3BofYgIEiVlHSpsI10w2Vi12p4tFHmm7d6hGMxlv p8hTVXPd2fxe98WmDN3uwt0rMiGFqH5KUe+WKCKZBpcOuqeFozoUMHYIfHI8sA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602086579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/O9zXhP69EMhj/QeCm7nrD9DQq4LE8NEMX5F2vVATgA=; b=aqWokfyvspmV4iCEpYaILBtp6cY+vo8aEECP6c1adQSHnVnLCtdUwT+etJqIziH+dADdSA AAKK0fqcfKGuzjAA== To: David Woodhouse , x86@kernel.org Subject: Re: [PATCH 10/13] x86/irq: Limit IOAPIC and MSI domains' affinity without IR In-Reply-To: <1b1fda3079627748e1f5084ddae8a686258c78d9.camel@infradead.org> References: <77e64f977f559412f62b467fd062d051ea288f14.camel@infradead.org> <20201005152856.974112-1-dwmw2@infradead.org> <20201005152856.974112-10-dwmw2@infradead.org> <87d01v58bw.fsf@nanos.tec.linutronix.de> <874kn65h0r.fsf@nanos.tec.linutronix.de> <87imbm3zdq.fsf@nanos.tec.linutronix.de> <1b1fda3079627748e1f5084ddae8a686258c78d9.camel@infradead.org> Date: Wed, 07 Oct 2020 18:02:59 +0200 Message-ID: <877ds23txo.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Cc: Paolo Bonzini , iommu , linux-hyperv@vger.kernel.org, kvm X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Oct 07 2020 at 15:23, David Woodhouse wrote: > On Wed, 2020-10-07 at 16:05 +0200, Thomas Gleixner wrote: >> On Wed, Oct 07 2020 at 14:08, David Woodhouse wrote: >> > On 7 October 2020 13:59:00 BST, Thomas Gleixner wrote: >> > > On Wed, Oct 07 2020 at 08:48, David Woodhouse wrote: >> > > > To fix *that* case, we really do need the whole series giving us per- >> > > > domain restricted affinity, and to use it for those MSIs/IOAPICs that >> > > > the IRQ remapping doesn't cover. >> > > >> > > Which do not exist today. >> > >> > Sure. But at patch 10/13 into this particular patch series, it *does* >> > exist. >> >> As I told you before: Your ordering is wrong. We do not introduce bugs >> first and then fix them later .... > > I didn't introduce that bug; it's been there for years. Fixing it > properly requires per-irqdomain affinity limits. > > There's a cute little TODO at least in the Intel irq-remapping driver, > noting that we should probably check if there are any IOAPICs that > aren't in the scope of any DRHD at all. But that's all. So someone forgot to remove the cute little TODO when this was added: if (parse_ioapics_under_ir()) { pr_info("Not enabling interrupt remapping\n"); goto error; } Thanks, tglx _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu