From: Thomas Gleixner <tglx@linutronix.de>
To: Sean Christopherson <seanjc@google.com>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Robert Lippert <rlippert@google.com>,
Wentao Yang <wentaoyang@google.com>,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH] iommu/vt-d: Wire up irq_ack() to irq_move_irq() for posted MSIs
Date: Fri, 21 Mar 2025 21:43:38 +0100 [thread overview]
Message-ID: <87ldsy15dx.ffs@tglx> (raw)
In-Reply-To: <20250321194249.1217961-1-seanjc@google.com>
On Fri, Mar 21 2025 at 12:42, Sean Christopherson wrote:
> Set the posted MSI irq_chip's irq_ack() hook to irq_move_irq() instead of
> a dummy/empty callback so that posted MSIs process pending changes to the
> IRQ's SMP affinity. Failure to honor a pending set-affinity results in
> userspace being unable to change the effective affinity of the IRQ, as
> IRQD_SETAFFINITY_PENDING is never cleared and so irq_set_affinity_locked()
> always defers moving the IRQ.
>
> The issue is most easily reproducible by setting /proc/irq/xx/smp_affinity
> multiple times in quick succession, as only the first update is likely to
> be handled in process context.
>
> Fixes: ed1e48ea4370 ("iommu/vt-d: Enable posted mode for device MSIs")
> Cc: Robert Lippert <rlippert@google.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Reported-by: Wentao Yang <wentaoyang@google.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
prev parent reply other threads:[~2025-03-21 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 19:42 [PATCH] iommu/vt-d: Wire up irq_ack() to irq_move_irq() for posted MSIs Sean Christopherson
2025-03-21 20:43 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldsy15dx.ffs@tglx \
--to=tglx@linutronix.de \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rlippert@google.com \
--cc=seanjc@google.com \
--cc=wentaoyang@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox