From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 3/4] iommu/rockchip: Play nice in multi-platform builds Date: Thu, 05 Feb 2015 09:30:28 +0100 Message-ID: <8897595.h8gfmnfTfF@phil> References: <1423036690-3862-1-git-send-email-thierry.reding@gmail.com> <1423036690-3862-4-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423036690-3862-4-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Thierry Reding Cc: Nicolas Chauvet , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Daniel Kurtz List-Id: iommu@lists.linux-foundation.org Hi Thierry, Am Mittwoch, 4. Februar 2015, 08:58:09 schrieb Thierry Reding: > From: Thierry Reding > > The Rockchip IOMMU driver unconditionally executes code and registers a > struct iommu_ops with the platform bus irrespective of whether it runs > on a Rockchip SoC or not. This causes problems in multi-platform kernels > where drivers for other SoCs will no longer be able to register their > own struct iommu_ops or even try to use a struct iommu_ops for an IOMMU > that obviously isn't there. > > The smallest fix I could think of is to check for the existence of any > Rockchip IOMMU devices in the device tree and skip initialization > otherwise. > > This fixes a problem on Tegra20 where the DRM driver will try to use the > obviously non-existent Rockchip IOMMU. > > Reported-by: Nicolas Chauvet > Cc: Heiko Stuebner > Cc: Daniel Kurtz > Signed-off-by: Thierry Reding Reviewed-by: Heiko Stuebner on a rk3288-firefly with drm through the hdmi connector Tested-by: Heiko Stuebner